Skip to content

/ brave-core-crx-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chromium themes extension since it is unused #63

Merged
merged 2 commits into from May 23, 2019
Merged

Remove Chromium themes extension since it is unused #63

merged 2 commits into from May 23, 2019

Conversation

@bbondy
Copy link
Member

bbondy commented May 22, 2019 •
edited

Fix #62

If we have Jenkins jobs that run:
npm run package-themes
npm run upload-themes

Then we could remove them.
@bbondy
Remove Chromium themes extension since it is unused
16d2fca
@bbondy bbondy requested review from mihaiplesa and emerick May 22, 2019
@bbondy bbondy self-assigned this May 22, 2019
@emerick
emerick approved these changes May 22, 2019
View changes
Copy link
Contributor

emerick left a comment

LGTM, can probably remove the relevant section in README.md as well.
@mihaiplesa
Copy link

mihaiplesa commented May 22, 2019

Have removed the relevant Jenkins jobs.
@bbondy
Remove theme extension info from README
e1af477
@bbondy bbondy merged commit 9aa333d into master May 23, 2019
@bsclifton bsclifton deleted the chromium-themes-removal branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick

@mihaiplesa mihaiplesa

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove Chromium themes scripts since it is unused
3 participants
@bbondy @mihaiplesa @emerick
You can’t perform that action at this time.