Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json for new https-everywhere-builder deps #71

Merged

Conversation

@fmarier
Copy link
Member

fmarier commented Aug 15, 2019

Fixes #70

This PR is a result of running npm install twice in the repo.

To test this branch, I:

  1. deleted the node_modules directory
  2. ran npm install
  3. verified package-lock.json is unchanged
  4. ran npm run data-files-https-everywhere
Copy link
Member

petemill left a comment

Approving extra dependencies since these are brought in via the already-approved changes in brave/https-everywhere-builder

@petemill petemill merged commit baf40f9 into brave:master Aug 15, 2019
@fmarier fmarier deleted the fmarier:update-https-everywhere-builder-dependencies-70 branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.