From ab1f6c869ab71746ca38110a0f6236e940d28ae1 Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Fri, 19 Jan 2024 21:20:18 +0900 Subject: [PATCH] Updated omnibox chip button's background color in light mode (#21637) fix https://github.com/brave/brave-browser/issues/35358 --- browser/ui/color/brave_color_mixer.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/browser/ui/color/brave_color_mixer.cc b/browser/ui/color/brave_color_mixer.cc index 4388de002d08e..34891f43d8567 100644 --- a/browser/ui/color/brave_color_mixer.cc +++ b/browser/ui/color/brave_color_mixer.cc @@ -242,6 +242,12 @@ void AddChromeLightThemeColorMixer(ui::ColorProvider* provider, ui::kColorFocusableBorderFocused}; mixer[kColorTabFocusRingActive] = {ui::kColorFocusableBorderFocused}; mixer[kColorTabFocusRingInactive] = {ui::kColorFocusableBorderFocused}; + + // Upstream uses tab's background color as omnibox chip background color. + // In our light mode, there is no difference between location bar's bg + // color and tab's bg color. So, it looks like chip's bg color is transparent. + // Use frame color as chip background to have different bg color. + mixer[kColorOmniboxChipBackground] = {kLightFrame}; } void AddChromeDarkThemeColorMixer(ui::ColorProvider* provider,