Sync v2 #1019

cezaraugusto · 2018-12-04T17:07:10Z

fix brave/brave-browser#2253
fix brave/brave-browser#2131
fix brave/brave-browser#2128
fix brave/brave-browser#2123

Auditors: @AlexeyBarabash @darkdh
cc @petemill for front-end code review

Notes: Sync v2 flow changed:

Users can't type device name anymore;
You can only start with a sync chain w/ at least 2 devices;
A chain with less than 2 devices will be reset.

Test Plan:

Adding/Syncing devices

Have two different devices or open two browser instances w/ different profiles via diffrent user_data_dir_name
Sync words should work. if you are able to test qrcode, it should work too
Bookmarks syncing switch should be on by default. Bookmarking a page should appear in the connected device within 1 minute which is the time sync takes to fetch updates

Removing devices

After being synced with two devices, try removing one
The main device should have a different modal popup than the remote device
If you have only two devices and remove one, Sync should reset

Error cases

No internet

Start Sync in a fresh profile and click either "Start a new sync chain" or "Enter a sync chain code" buttons
Disable internet in your OS (not via devtools)
Go back to the sync screen
You should see a No internet connection. error dialog

Wrong passphrase

Start Sync in a fresh profile and go to "Enter a Sync chain code"
Type anything honest that is not a Sync word i.e. anthony is the boss
You should see a Invalid sync code. error dialog. He's still the boss tho.

Bad behavior from Sync servers

Create a sync chain and ensure you see two devices
Quit Brave
Launch Brave without internet
You should see a Unable to connect to the Sync servers. error dialog

petemill

@cezaraugusto I've done a first pass on the code, and same comments as #894 wrt the images. If they can be put in brave-ui alongside where they are used, when they are static, that would be best. If not then they could be placed inside this component instead of the generic brave-core/img directory which we are looking to remove. And we at least don't need to specify then in the GRD or c++ since that is all automatically handled via webpack now.

However I would like to test the functionality further. Is there a test plan, at least for QA? I can't see one on the main sync v2 issue.

components/resources/brave_components_resources.grd

package.json

browser/ui/webui/brave_webui_source.cc

AlexeyBarabash

Approving because PR does not contain native changes I would reject.

darkdh

I have two Mac and I can't tell which is which
Sync Bookmark can not be toggled on and it should be default on

cezaraugusto · 2018-12-12T02:10:26Z

@darkdh you can see who they are via main device words. ping @bradleyrichter re #1019 (review) do you think this could be a usability issue?

cezaraugusto · 2018-12-12T02:10:45Z

@darkdh @AlexeyBarabash @petemill sync v2 is ready for re-review

AlexeyBarabash · 2018-12-12T15:04:29Z

Thanks, @cezaraugusto . Looks fresh comparing to v1.

I am not a designer, but maybe the content should be centered vertically.

AlexeyBarabash · 2018-12-12T15:14:42Z

@cezaraugusto
I like the button Copy to clipboard when I copy the code from the device in chain.

But when I connect device to existing sync chain, I also have the Copy to clipboard button.
Is it possible to make Paste from clipboard button? Or remove Copy to clipboard when entering sync code.

AlexeyBarabash · 2018-12-12T15:20:15Z

I also have two Linux devices and cannot distinguish them

cezaraugusto · 2018-12-12T16:47:54Z

@AlexeyBarabash thanks for reviewing

re <textarea> comment I removed the copy option. we don't have the paste feature in brave-ui and wouldn't make for this change anyway
re first screen positioning that is following the design spec
re the option to distinguish between devices I've bring that up to design in https://bravesoftware.slack.com/archives/C2HJYB45N/p1544587433023800

srirambv · 2018-12-12T16:50:03Z

@cezaraugusto @AlexeyBarabash @darkdh Is it possible to add a check for unique device names at the time of joining a sync group?

feedback regarding main device/this device addressed

petemill · 2018-12-12T18:36:43Z

components/brave_sync/ui/components/modals/deviceType.tsx

+        }
+        {
+          scanCode
+          ? <ScanCodeModal syncData={syncData} actions={actions} onClose={this.onClickPhoneTabletButton} />


ux nit: we are opening a modal on top of another modal, can't we re-use the same modal? Right now this requires two clicks of the close button to get back to the beginning.

bradleyrichter · 2018-12-12T18:59:29Z

@cezaraugusto "main device" should be "this device" which will cover MOST cases where the device names are the same.

For linux, are we not able to get the device names?

petemill

Some ux nits that can be considered for follow-ups.

However, I had an issue with moving a bookmark in to a folder - the other device did not update to move the bookmark. But I guess that is not a problem with the front-end in this PR.

I did also try the no-internet error test and I did not receive an alert at all when I restarted the browser, even though I could not access any web sites in the browser due to no network connection. That is also not in this PR, right @cezaraugusto @darkdh ?

Based on these assumptions, LGTM, but please correct me if I'm wrong.

1

ux nit: table column spacing (and button column could collapse to above / below table)

2

ux nit: This line-height feels extremely cramped and uneven

3

ux nit: we are opening a modal on top of another modal to start the experience. Should we re-use the same modal? Right now this requires two clicks of the close button to get back to the beginning.

4

ux nit: the toggles seem to have an extra couple of blank rows which I presume is from disabled sync types. But this creates an arbitrary amount of space. If we want the button to have margin then we can specify a margin, but I doubt this is the exact space that we want

petemill · 2018-12-12T18:59:26Z

package.json

@@ -272,7 +272,7 @@
    "@types/react-dom": "^16.0.7",
    "@types/react-redux": "6.0.4",
    "awesome-typescript-loader": "^5.2.0",
-    "brave-ui": "brave/brave-ui#cee363dd33ec3c7499b7d239384a6f2eb601f981",
+    "brave-ui": "github:brave/brave-ui#2b8e852f5585342594bfaf29a2d392ba2fe72b81",


We need to remember not to merge this PR until this brave-ui commit is on brave-ui master.
Steps:

get this PR approved

merge brave-ui requirements to brave-ui master

point this PR at latest brave-ui master

merge this PR

petemill · 2018-12-12T19:10:50Z

@bradleyrichter @rossmoody I left some UX feedback above that we should follow-up on

darkdh · 2018-12-12T19:30:03Z

@petemill offline should trigger an alert. If you can not see that in this PR, then it is a regression.

bbondy

carrying forward r+ after rebase, not actually reviewed by me.

petemill · 2018-12-12T20:20:19Z

@kjozwiak @rebron @srirambv just to confirm that this is going on 0.58.x

@petemill

auditor: @petemill - ref brave/brave-ui@c31aafc

petemill

approved brave-ui sha change

Sync v2

cezaraugusto · 2018-12-12T20:37:33Z

master 9dedff7
0.60.x 205dbf4
0.59.x ce201a1 (this change) d8e1834 (brave-ui sha update)
0.58.x 1e72e55 (this change) 9b61a05 (brave-ui sha update)

AlexeyBarabash · 2018-12-13T12:38:30Z

I cannot start a new chain when this PR was merged.
Have a clean profile.

Press Start a new sync chain
It prompts to choose a new device
I want to choose mobile, but get no QR code

3-2) I want to choose a desktop, it wants to have a sync chain code

AlexeyBarabash · 2018-12-13T15:17:37Z

Cannot see above on mac. Maybe this is my local Linux build issue.

cezaraugusto self-assigned this Dec 4, 2018

cezaraugusto requested review from petemill, darkdh and AlexeyBarabash December 4, 2018 17:07

petemill previously requested changes Dec 5, 2018

View reviewed changes

AlexeyBarabash reviewed Dec 5, 2018

View reviewed changes

darkdh previously requested changes Dec 5, 2018

View reviewed changes

cezaraugusto mentioned this pull request Dec 6, 2018

make sync images exportable brave/brave-ui#308

Merged

cezaraugusto force-pushed the sync2 branch 3 times, most recently from 2b82f2f to 9edbbd2 Compare December 12, 2018 02:08

cezaraugusto force-pushed the sync2 branch 2 times, most recently from 8344f9c to 272fc6b Compare December 12, 2018 16:47

cezaraugusto force-pushed the sync2 branch from 272fc6b to e58ed1b Compare December 12, 2018 16:48

petemill reviewed Dec 12, 2018

View reviewed changes

petemill previously approved these changes Dec 12, 2018

View reviewed changes

This was referenced Dec 12, 2018

Sync v2 usability issues brave/brave-browser#2500

Closed

Sync device name should have restricted length #916

Closed

replace main device w/ this device

67b98e3

cezaraugusto dismissed petemill’s stale review via 67b98e3 December 12, 2018 20:03

cezaraugusto force-pushed the sync2 branch from cdbd758 to 67b98e3 Compare December 12, 2018 20:03

bbondy previously approved these changes Dec 12, 2018

View reviewed changes

use the correct brave-ui sha revision for master

36fcef2

auditor: @petemill - ref brave/brave-ui@c31aafc

cezaraugusto dismissed bbondy’s stale review via 36fcef2 December 12, 2018 20:21

petemill added the uplift-approved/0.58.x-Release label Dec 12, 2018

petemill approved these changes Dec 12, 2018

View reviewed changes

cezaraugusto merged commit 9dedff7 into master Dec 12, 2018

cezaraugusto deleted the sync2 branch December 12, 2018 20:23

cezaraugusto added a commit that referenced this pull request Dec 12, 2018

Merge pull request #1019 from brave/sync2

205dbf4

Sync v2

cezaraugusto added a commit that referenced this pull request Dec 12, 2018

Merge pull request #1019 from brave/sync2

ce201a1

Sync v2

cezaraugusto added a commit that referenced this pull request Dec 12, 2018

Merge pull request #1019 from brave/sync2

1e72e55

Sync v2

cezaraugusto added merged/0.58.x-Release and removed uplift-approved/0.58.x-Release labels Dec 12, 2018

srirambv mentioned this pull request Dec 14, 2018

Sync warn modal needs refactoring brave/brave-browser#2128

Closed

GeetaSarvadnya mentioned this pull request Dec 14, 2018

Reset sync warning message needs to be Refactored brave/brave-browser#2253

Closed

bbondy added this to the 0.58.x - Release milestone Jan 14, 2019

This was referenced Jan 9, 2020

Fixes contribution with unblinded tokens #4317

Merged

Default OOP rasterization to off (original value) #4318

Merged

Fixes unable to get ad tokens if tokens are not ready #4334

Merged

This was referenced Jan 15, 2020

Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly #4133

Merged

Intermittent crash if Confirmations library is called before being instantiated #4370

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync v2 #1019

Sync v2 #1019

cezaraugusto commented Dec 4, 2018 •

edited

Loading

petemill left a comment

AlexeyBarabash left a comment

darkdh left a comment

cezaraugusto commented Dec 12, 2018

cezaraugusto commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

cezaraugusto commented Dec 12, 2018

srirambv commented Dec 12, 2018

petemill Dec 12, 2018

bradleyrichter commented Dec 12, 2018

petemill left a comment •

edited

Loading

petemill Dec 12, 2018

petemill commented Dec 12, 2018

darkdh commented Dec 12, 2018

bbondy left a comment

petemill commented Dec 12, 2018

petemill left a comment

cezaraugusto commented Dec 12, 2018

AlexeyBarabash commented Dec 13, 2018

AlexeyBarabash commented Dec 13, 2018

Sync v2 #1019

Sync v2 #1019

Conversation

cezaraugusto commented Dec 4, 2018 • edited Loading

Test Plan:

Adding/Syncing devices

Removing devices

Error cases

No internet

Wrong passphrase

Bad behavior from Sync servers

petemill left a comment

Choose a reason for hiding this comment

AlexeyBarabash left a comment

Choose a reason for hiding this comment

darkdh left a comment

Choose a reason for hiding this comment

cezaraugusto commented Dec 12, 2018

cezaraugusto commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

AlexeyBarabash commented Dec 12, 2018

cezaraugusto commented Dec 12, 2018

srirambv commented Dec 12, 2018

petemill Dec 12, 2018

Choose a reason for hiding this comment

bradleyrichter commented Dec 12, 2018

petemill left a comment • edited Loading

Choose a reason for hiding this comment

1

2

3

4

petemill Dec 12, 2018

Choose a reason for hiding this comment

petemill commented Dec 12, 2018

darkdh commented Dec 12, 2018

bbondy left a comment

Choose a reason for hiding this comment

petemill commented Dec 12, 2018

petemill left a comment

Choose a reason for hiding this comment

cezaraugusto commented Dec 12, 2018

AlexeyBarabash commented Dec 13, 2018

AlexeyBarabash commented Dec 13, 2018

cezaraugusto commented Dec 4, 2018 •

edited

Loading

petemill left a comment •

edited

Loading