Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private new tab page #105

Merged
merged 3 commits into from Jun 7, 2018
Merged

Add private new tab page #105

merged 3 commits into from Jun 7, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented May 15, 2018

closes brave/brave-browser#200

Note: private search engine toggle is only aesthetic at this moment.

screen shot 2018-05-15 at 3 09 45 am

@cezaraugusto cezaraugusto self-assigned this May 15, 2018
@cezaraugusto cezaraugusto requested a review from bbondy May 15, 2018
Copy link
Member

@bbondy bbondy left a comment

If I'm reading this right then it looks like you're adding brave-extension as a submodule. It should instead just be automatically downloaded after the npm run init so pls remove that if it was added as a submodule here. I might be misreading the PR though?
"Submodule brave-extension added at 510031"

{ "6d23ab5117038380fd25f70909340a87.woff2", IDR_BRAVE_TEXT_FONT_MULI_800_NORMAL_LATIN_EXT },
{ "ed853eeb06da3de8325c2a4abddc30c8.woff2", IDR_BRAVE_TEXT_FONT_MULI_800_NORMAL_LATIN },
{ "7d0f2d0b966f31e8bc75bcf6954b6b49.woff2", IDR_BRAVE_TEXT_FONT_MULI_900_NORMAL_LATIN_EXT },
{ "18a1df59976e7a18fed257368aaafa9f.woff2", IDR_BRAVE_TEXT_FONT_MULI_900_NORMAL_LATIN },
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we only include the fonts that are used?

},
{
"name": "Cezar Augusto",
"email": "cezar@brave.com"
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

// TODO
// return <NewPrivateTab newTabData={newTabData} />
return null
return <NewPrivateTab stats={newTabData.stats} />
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Height needs to be adjusted here so it takes up the whole height for the background.
screen shot 2018-05-22 at 1 04 36 pm

}
}

module.exports = Clock
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this removed from here! 👍

fontFamily: '"Poppins", sans-serif',
color: 'rgba(255,255,255,0.8)',
padding: '80px 60px 40px',
background: 'linear-gradient(#4b3c6e, #000)'
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some of this factored out from the inline component structure?

<SwitchButton
id='togglePrivateSearchEngine'
size='large'
checked={false /* TODO: enable search engine change */}
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put a dummy handler for now that calls to the reducer. Currently when you click the switch:
screen shot 2018-05-22 at 1 16 56 pm

counter={timeSaved.value}
text={window.loadTimeData.getString(timeSaved.id)}
description={window.loadTimeData.getString('estimatedTimeSaved')} />
</DataBlock>
Copy link
Member

@bbondy bbondy May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto some of these inline values, wondering if we should have a separate parameters js file or have the styles in css.

@cezaraugusto cezaraugusto force-pushed the about/newtab/private branch 2 times, most recently from 3c82f5c to 3a1affa Compare May 30, 2018
@cezaraugusto
Copy link
Contributor Author

@cezaraugusto cezaraugusto commented May 30, 2018

ya, re #105 (review) seems like after an incremental build those files are added momentarily. Not sure what happened but removed from git. Other feedback addressed too, thanks!

@cezaraugusto cezaraugusto force-pushed the about/newtab/private branch 2 times, most recently from 5f0076b to b277e14 Compare May 30, 2018
Copy link
Member

@bbondy bbondy left a comment

I'm ok with the changes but I think there's problem with some of the included resources: No such file or directory: u'../../out/Debug/gen/brave/1559d981ccec8dc4b4feb9043271ab3d.woff2'

Also I think there are more .woff2 files added than defined in the css and in the grd.

@cezaraugusto cezaraugusto force-pushed the about/newtab/private branch 3 times, most recently from c8f2b81 to 91e1044 Compare Jun 7, 2018
@bbondy bbondy force-pushed the about/newtab/private branch from 91e1044 to 4a6671d Compare Jun 7, 2018
cezaraugusto added 3 commits Jun 7, 2018
-
includes images, fonts and locale strings used in private newtab page
-
this avoid the require of 6 fonts for newtab page
@bbondy bbondy force-pushed the about/newtab/private branch from 91e1044 to 9fe0aa3 Compare Jun 7, 2018
bbondy
bbondy approved these changes Jun 7, 2018
@bbondy
Copy link
Member

@bbondy bbondy commented Jun 7, 2018

Nice work!

@bbondy bbondy merged commit 9076b5f into master Jun 7, 2018
@cezaraugusto cezaraugusto deleted the about/newtab/private branch Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants