Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default pref for setting preserve profile pref #111

Merged
merged 1 commit into from May 21, 2018
Merged

Use default pref for setting preserve profile pref #111

merged 1 commit into from May 21, 2018

Conversation

@bbondy
Copy link
Member

bbondy commented May 21, 2018 •
edited

Fix: brave/brave-browser#191

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
@bbondy bbondy self-assigned this May 21, 2018
@bbondy bbondy requested a review from bridiver May 21, 2018
@bbondy
Use default pref for setting preserve profile pref
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: C063402E6BCBEFAD Learn about signing commits
68b54e3 
Fix: brave/brave-browser#191
@bbondy bbondy force-pushed the startup-pref-2 branch from 8c0f8c3 to 68b54e3 May 21, 2018
@bridiver
bridiver approved these changes May 21, 2018
View changes
@bbondy bbondy merged commit bb2a6cb into master May 21, 2018
@bsclifton bsclifton deleted the startup-pref-2 branch Jun 18, 2018
NejcZdovc added a commit that referenced this pull request Dec 10, 2018
@NejcZdovc
Merge pull request #111 from brave-intl/fix/auto-cont-off
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
29e7547 
Web sites should now not be added to auto contribute if user has not opted into rewards
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #111 from mbacchi/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6cd1915 
Include 'yarn install' step before 'yarn run init'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bbondy @bridiver
You can’t perform that action at this time.