Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable brave ads on linux #1150

Merged
merged 1 commit into from Dec 19, 2018
Merged

temporarily disable brave ads on linux #1150

merged 1 commit into from Dec 19, 2018

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Dec 19, 2018

fix brave/brave-browser#2656

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@bridiver bridiver self-assigned this Dec 19, 2018
@bridiver bridiver requested a review from tmancey Dec 19, 2018
@bridiver bridiver merged commit d5b11e9 into master Dec 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bridiver bridiver deleted the issues/2656 branch Dec 19, 2018
bridiver added a commit that referenced this pull request Dec 20, 2018
temporarily disable brave ads on linux
@bridiver
Copy link
Collaborator Author

bridiver commented Dec 20, 2018

0.60.x 6a56a89
0.59 be8c77c

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

tmancey added a commit that referenced this pull request Dec 20, 2018
temporarily disable brave ads on linux
@bbondy
Copy link
Member

bbondy commented Dec 20, 2018

Pls remember to set milestone when merging on the associated issue. I did for this one.

@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.