Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes custom publisher tipping amounts #1164

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fixes custom publisher tipping amounts #1164

merged 1 commit into from
Dec 21, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 20, 2018

Fixes: brave/brave-browser#2645

Turns out this already worked, just needed to change from amount -> amounts in the donate state enum.

Also updated the check to look for amounts.length, as if there are no custom amounts, we just get an empty list back.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Enable Rewards
  2. Navigate to https://kjozwiak.github.io/
  3. Open panel, hit 'Send Tip' to bring up site banner
  4. Ensure that the donation amount choices reflect the customizations made to the publisher banner

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit 2bd242d into master Dec 21, 2018
@NejcZdovc NejcZdovc deleted the fix-2645 branch December 21, 2018 06:08
NejcZdovc added a commit that referenced this pull request Dec 21, 2018
Fixes custom publisher tipping amounts
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Dec 21, 2018

master (0.61) 2bd242d
0.60 3a37a03
0.59 fa94258

@rebron
Copy link
Collaborator

rebron commented Dec 21, 2018

Approving uplift request. cc: @kjozwiak @srirambv

NejcZdovc added a commit that referenced this pull request Dec 21, 2018
Fixes custom publisher tipping amounts
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom tip amount for publishers
4 participants