Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store notifications on every add, delete #1308

Merged
merged 2 commits into from Jan 11, 2019
+3 −1
Merged

Store notifications on every add, delete #1308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8658c
Store notifications on every add, delete
SergeyZhukovsky Jan 11, 2019
53e9450
don't store notification on destructor
SergeyZhukovsky Jan 11, 2019
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

don't store notification on destructor

  • Loading branch information
@SergeyZhukovsky
SergeyZhukovsky committed Jan 11, 2019
commit 53e94500ce07ced37fd5c1d6d3373554c6849a6d
1 components/brave_rewards/browser/rewards_notification_service_impl.cc
View file
Open in desktop
@@ -37,7 +37,6 @@ RewardsNotificationServiceImpl::RewardsNotificationServiceImpl(Profile* profile)
}

RewardsNotificationServiceImpl::~RewardsNotificationServiceImpl() {
StoreRewardsNotifications();
#if BUILDFLAG(ENABLE_EXTENSIONS)
RemoveObserver(extension_rewards_notification_service_observer_.get());
#endif
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.