Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not attempt to close `enter sync words` dialog when error is found #1357

Merged
merged 1 commit into from Jan 17, 2019
Merged

do not attempt to close `enter sync words` dialog when error is found #1357

merged 1 commit into from Jan 17, 2019

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jan 16, 2019 •
edited

fix brave/brave-browser#2845

Test Plan (edited from brave/brave-browser#2845)

  1. launch brave (0.59.20 Chromium: 72.0.3626.28 in this instance)
  2. open brave://sync and click on I Have a Sync Code
  3. click on Confirm Sync Code without adding anything into the text field
  4. should not close modal
@cezaraugusto
do not attempt to close `enter sync words` dialog when error is found
Loading status checks…
ddba2a2 
fix brave/brave-browser#2845
@cezaraugusto cezaraugusto self-assigned this Jan 16, 2019
@cezaraugusto cezaraugusto requested a review from AlexeyBarabash Jan 16, 2019
@cezaraugusto cezaraugusto added this to the 0.61.x - Nightly milestone Jan 16, 2019
@AlexeyBarabash
AlexeyBarabash approved these changes Jan 16, 2019
View changes
Copy link
Contributor

AlexeyBarabash left a comment

looks good
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Jan 17, 2019

thanks!
@cezaraugusto cezaraugusto merged commit cecc055 into master Jan 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cezaraugusto cezaraugusto deleted the ca-2845 branch Jan 17, 2019
cezaraugusto added a commit that referenced this pull request Jan 17, 2019
@cezaraugusto
Merge pull request #1357 from brave/ca-2845
Loading status checks…
1cf6a3f 
do not attempt to close `enter sync words` dialog when error is found
cezaraugusto added a commit that referenced this pull request Jan 17, 2019
@cezaraugusto
Merge pull request #1357 from brave/ca-2845
Loading status checks…
67870ba 
do not attempt to close `enter sync words` dialog when error is found
This was referenced Jan 17, 2019
Merged
Merged
@btlechowski btlechowski mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash

Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync
Projects
None yet
Milestone
  0.61.x - Release
Linked issues

Successfully merging this pull request may close these issues.

warning not being displayed the first time around when clicking on `Confirm Sync Code` without any code added
2 participants
@cezaraugusto @AlexeyBarabash
You can’t perform that action at this time.