Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not attempt to close `enter sync words` dialog when error is found #1381

Merged
merged 1 commit into from Jan 17, 2019
Merged

do not attempt to close `enter sync words` dialog when error is found #1381

merged 1 commit into from Jan 17, 2019

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jan 17, 2019 •
edited by kjozwiak

Fix: brave/brave-browser#2845
#1357 version for 0.59.x
@cezaraugusto
Merge pull request #1357 from brave/ca-2845
Loading status checks…
67870ba 
do not attempt to close `enter sync words` dialog when error is found
@cezaraugusto cezaraugusto added this to the 0.59.x - Beta milestone Jan 17, 2019
@cezaraugusto cezaraugusto self-assigned this Jan 17, 2019
@rebron
rebron approved these changes Jan 17, 2019
View changes
Copy link
Collaborator

rebron left a comment

Looks good.
@cezaraugusto cezaraugusto merged commit 0f5b6c4 into 0.59.x Jan 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cezaraugusto cezaraugusto deleted the ca-2845-59 branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebron rebron

@kjozwiak kjozwiak

@bsclifton bsclifton

@srirambv srirambv

Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync
Projects
None yet
Milestone
  0.59.x - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cezaraugusto @rebron
You can’t perform that action at this time.