Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block incorrect IPFS\IPNS urls. #14211

Merged
merged 1 commit into from Jul 19, 2022
Merged

Block incorrect IPFS\IPNS urls. #14211

merged 1 commit into from Jul 19, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Jul 18, 2022

Fixes brave/brave-browser#24093
Don't allow to commit raw ipfs\ipns navigations.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

As described in the hackerone issue

Fixes brave/brave-browser#24093
Don't allow to commit raw ipfs\ipns navigations.
@cypt4 cypt4 requested a review from iefremov as a code owner July 18, 2022 07:50
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Jul 18, 2022
@cypt4 cypt4 merged commit e733096 into master Jul 19, 2022
15 of 25 checks passed
@cypt4 cypt4 deleted the brave_24093 branch July 19, 2022 14:04
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
2 participants