Add packages and libraries to filter list for dep checking on linux #150

bkero · 2018-06-07T19:37:13Z

This commit is in reference to brave/brave-browser#305

We still need to run the update script by hand though, to generate a
useful json file.

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed.

Test Plan:

Run a linux build with these patches applied.

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions


        Add packages and libraries to filter list for dep checking on linux

This commit is in reference to brave/brave-browser#305 We still need to run the update script by hand though, to generate a useful json file.

bridiver · 2018-06-07T19:58:03Z

patches/chrome-installer-linux-rpm-update_package_provides.py.patch

+     "libnssutil3.so",
+     "libpango-1.0.so",
+     "libpangocairo-1.0.so",
+    "libplc4.so",


what are these from?

bridiver · 2018-06-07T19:58:27Z

patches/chrome-installer-linux-rpm-update_package_provides.py.patch

+    "libplc4.so",
+    "libplds4.so",
+     "libpthread.so",
+    "libresolv.so.2",


These are both from https://staging.ci.brave.com/job/brave-browser-build-linux/28/console
(The same is reflected in the linked issue)

must be deps of the new deps. Ok

bridiver · 2018-06-07T20:00:19Z

patches/chrome-installer-linux-debian-update_dist_package_versions.py.patch

+     "libatk-bridge2.0-0",
+     "libc6",
+     "libcairo2",
+    "libcairo-gobject2",


I think we'll be less likely to run into conflicts if we put these at the top of the list instead of keeping the alphabetical order - same with the other file


        Merge pull request #150 from brave-intl/upgrade-path

Adds upgrade path from 55.12-55.14


        Add CLI arg for starting without Brave extension

Fix #150 Related: #87 You can do this with: ``` npm run start -- --disable_brave_extension ``` or ``` yarn start --disable_brave_extension ```

Add packages and libraries to filter list for dep checking on linux

af4f48e

This commit is in reference to brave/brave-browser#305 We still need to run the update script by hand though, to generate a useful json file.

bkero requested review from bridiver, RyanJarv and mbacchi Jun 7, 2018

mbacchi approved these changes Jun 7, 2018

View changes

bkero merged commit 86d4d17 into brave:master Jun 7, 2018

bkero deleted the bkero:update-package-filter branch Jun 7, 2018

bridiver reviewed Jun 7, 2018

View changes

patches/chrome-installer-linux-rpm-update_package_provides.py.patch

"libnssutil3.so",

"libpango-1.0.so",

"libpangocairo-1.0.so",

+ "libplc4.so",

This comment has been minimized.

Sign in to view

Copy link

bridiver Jun 7, 2018
Collaborator

what are these from?

bridiver reviewed Jun 7, 2018

View changes

brave / brave-core

Add packages and libraries to filter list for dep checking on linux #150

Add packages and libraries to filter list for dep checking on linux #150

bkero commented Jun 7, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brave / brave-core

Join GitHub today

Add packages and libraries to filter list for dep checking on linux #150

Add packages and libraries to filter list for dep checking on linux #150

Conversation

bkero commented Jun 7, 2018

Submitter Checklist:

Test Plan:

Reviewer Checklist:

This comment has been minimized.

bridiver Jun 7, 2018

This comment has been minimized.

bridiver Jun 7, 2018

This comment has been minimized.

bkero Jun 7, 2018

This comment has been minimized.

bridiver Jun 7, 2018

This comment has been minimized.

bridiver Jun 7, 2018