Substitute chromium support urls

[yrliou]

This PR substitutes chromium support links to brave's community page, it's a part of solving brave/brave-browser#12.

commands used in url_constants.cc:

  %s/\".*.google.com.*\n\=.*;/\"https:\/\/community.brave.com\";
  %s/\".*.chrome.*.com.*\n\=.*;/\"https:\/\/community.brave.com\";
  %s/www.chromium.org/github.com\/brave\/brave-browser

Then, kUpgradeHelpCenterBaseURL is changed manually.

const char kUpgradeHelpCenterBaseURL[] =
    "https://community.brave.com?p=update_error&error=";

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions

[bridiver]

can we rewrite/redirect these urls instead of patching them? We have done that in other cases.

[yrliou]

Sorry, I'm not sure if I understood your comment correctly, I did copy the file into src/brave to rewrite these learn more urls instead of patching?

[yrliou]

Per offline discussion, rewriting the file is more reasonable than redirecting URLs because those URLs should not be redirected in other user scenarios and also we should avoid user seeing the original URL when they hover over those support links.
PR is updated by moving url_constants.cc into chromium_src to avoid unnecessary patching.

[simonhong]

This copying strategy has one problem - dependency check.
Modifying this copied file would not trigger rebuild common.lib static library target because common target doesn't know about copied url_constants.cc

[bridiver]

@simonhong if there's a problem with that then we need to fix how the chromium_src overrides work

[yrliou]

Did a test by modifying one url in the copied url_constants.cc and run yarn build again, the url change is reflected right away.

[simonhong]

It's interesting. how common target knows about our copied url_constants.cc?

[bridiver]

@simonhong I don't remember the exact details of how we implemented it in brave-core, but we setup chromium_src to allow overrides of chromium files.

[simonhong]

I need to study more about how cc_wrapper works :)

[simonhong]

I don't have any objection if this approach works well

[bridiver]

forgot to mention that you can just remove the GOOGLE_CHROME_BUILD stuff

[bridiver]

same with chromeos