Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect unsafe multithreaded access to httpse cache #1550

Merged
merged 1 commit into from Feb 1, 2019
Merged

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Feb 1, 2019

original PR #1546
protect unsafe multithreaded access to httpse cache

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
protect unsafe multithreaded access to httpse cache
@bridiver bridiver self-assigned this Feb 1, 2019
@bridiver bridiver requested review from bbondy and emerick Feb 1, 2019
@bridiver bridiver added this to the 0.61.x - Dev milestone Feb 1, 2019
@emerick
emerick approved these changes Feb 1, 2019
Copy link
Contributor

emerick left a comment

LGTM

@bridiver bridiver merged commit c605b4f into 0.61.x Feb 1, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bridiver bridiver deleted the issues/2970-0.61.x branch Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.