Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't use absolute path for signtool in sign_binaries.py #160
Conversation
script/sign_binaries.py
Outdated
| 'C:\\Program Files (x86)\\Windows Kits\\10')) | ||
| cmd = "{}\\bin\\x64\\signtool.exe {}".format(sdk_dir, signtool_args) | ||
| # signtool should be in the path if it was set up correctly by gn through src/build/vs_toolchain.py | ||
| cmd = 'signtool ' + format(signtool_args) |
This comment has been minimized.
This comment has been minimized.
bridiver
Jun 12, 2018
Collaborator
actually shouldn't this be 'signtool {}'.format(signtool_args)? I guess both ways work?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The env var checked before doesn't seem to get passed to this script and the fallback signtool path doesn't exist in a standard visual studios setup.
|
This allows us to work around the this issue brave/brave-browser#323. |
NejcZdovc
added a commit
that referenced
this pull request
Dec 10, 2018
Grant checks are now performed every 24 hours.
NejcZdovc
added a commit
that referenced
this pull request
Sep 18, 2019
Adds single panel option to the slider
NejcZdovc
added a commit
that referenced
this pull request
Sep 19, 2019
Adds single panel option to the slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RyanJarv commentedJun 12, 2018
•
edited
The env var checked before doesn't seem to get passed to this script and the fallback signtool path doesn't exist in a standard visual studios setup.
There's likely a better way to do this but this with setting the path before hand is the simplest fix for now. During the build it will look something like this:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: