Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable account consistency #170

Merged
merged 1 commit into from Jun 14, 2018
Merged

disable account consistency #170

merged 1 commit into from Jun 14, 2018

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Jun 13, 2018

fix brave/brave-browser#338

requires #172 for test

I tried setting prefs and several other methods to avoid patching, but this was the only thing that worked reliably

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
@bridiver bridiver self-assigned this Jun 13, 2018
@bridiver bridiver requested a review from bbondy Jun 13, 2018
@bridiver bridiver force-pushed the fix/338 branch from fffd436 to a727e17 Jun 14, 2018
@bbondy
bbondy approved these changes Jun 14, 2018
@bbondy bbondy merged commit 2e40eac into master Jun 14, 2018
@bridiver
Copy link
Collaborator Author

bridiver commented Jun 14, 2018

@bridiver
Copy link
Collaborator Author

bridiver commented Jun 14, 2018

@bsclifton bsclifton deleted the fix/338 branch Jun 18, 2018
NejcZdovc added a commit that referenced this pull request Dec 10, 2018
Grant fetch timestamp is now reset when no grants are available
NejcZdovc added a commit that referenced this pull request Dec 11, 2018
Grant fetch timestamp is now reset when no grants are available
NejcZdovc pushed a commit that referenced this pull request Sep 18, 2019
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
…n for Box
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
…n for Box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.