Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updisable account consistency #170
Merged
Conversation
|
see https://bugs.chromium.org/p/chromium/issues/detail?id=831824 for upstream issue |
|
check upstream fix https://chromium.googlesource.com/chromium/src.git/+/4fd11d48d6c82826fe8c84aaaf81d9449d81c23e when available and remove |
NejcZdovc
added a commit
that referenced
this pull request
Dec 10, 2018
Grant fetch timestamp is now reset when no grants are available
NejcZdovc
added a commit
that referenced
this pull request
Dec 11, 2018
Grant fetch timestamp is now reset when no grants are available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedJun 13, 2018
•
edited
fix brave/brave-browser#338
requires #172 for test
I tried setting prefs and several other methods to avoid patching, but this was the only thing that worked reliably
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: