Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Brave Rewards browser tests #1804
Merged
Conversation
7b6699d
to
7a0d8bd
623f82f
to
929138e
|
@NejcZdovc Officially ready for review! |
bba6eaf
to
fe1494d
|
Just left some comments. |
9bc199b
to
9975e10
|
@emerick can you please rebase |
9210ef1
to
f69a164
|
@NejcZdovc Sure, should be all set now. |
components/brave_rewards/browser/rewards_service_browsertest.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/rewards_service_browsertest.cc
Outdated
Show resolved
Hide resolved
fad7368
to
db3d58a
637b9d2
to
5bc48d1
|
e173d41
to
43abf96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emerick commentedFeb 28, 2019
•
edited
Fix brave/brave-browser#3161
Requires brave/brave-ui#417
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
npm test brave_unit_tests && npm test brave_browser_testsIndividual tests are described in detail in:
https://docs.google.com/document/d/1Mwu9STT-AYHVP7mgbmQkOXgYkdmKrPJTj8bYuLVK6nc
Reviewer Checklist: