Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDetermine third-party status in Brave-Core #1813
Merged
Conversation
|
LGTM |
|
LGTM |
bbondy
added a commit
that referenced
this pull request
Mar 1, 2019
Determine third-party status in Brave-Core
bbondy
added a commit
that referenced
this pull request
Mar 1, 2019
Determine third-party status in Brave-Core
This was referenced Mar 1, 2019
bbondy
added a commit
that referenced
this pull request
Mar 1, 2019
bbondy
added a commit
that referenced
this pull request
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedMar 1, 2019
•
edited
Fix: brave/brave-browser#3535
See also: brave/ad-block#188
Currently ad-block determines third party by sub-domain rules.
It should instead do eTLD+1 for this detection.
This makes it work more closely to uBlock and other ad-blocking libraries.
Note to reviewer:
I will update DEPS after the above
brave/ad-blockPR is landed.Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: