Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine third-party status in Brave-Core #1813

Merged
merged 2 commits into from Mar 1, 2019
Merged

Conversation

@bbondy
Copy link
Member

bbondy commented Mar 1, 2019

Fix: brave/brave-browser#3535
See also: brave/ad-block#188

Currently ad-block determines third party by sub-domain rules.
It should instead do eTLD+1 for this detection.
This makes it work more closely to uBlock and other ad-blocking libraries.

Note to reviewer:
I will update DEPS after the above brave/ad-block PR is landed.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@bbondy bbondy added this to the 0.63.x - Nightly milestone Mar 1, 2019
@bbondy bbondy self-assigned this Mar 1, 2019
@bbondy bbondy requested review from emerick and SergeyZhukovsky Mar 1, 2019
@bbondy bbondy force-pushed the determine-3p-in-brave-core branch from 4159feb to 6a7bc13 Mar 1, 2019
@bbondy bbondy requested a review from pes10k Mar 1, 2019
Copy link
Contributor

emerick left a comment

LGTM

@emerick
emerick approved these changes Mar 1, 2019
Copy link
Contributor

emerick left a comment

LGTM

@bbondy bbondy merged commit 2b1569c into master Mar 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bbondy added a commit that referenced this pull request Mar 1, 2019
Determine third-party status in Brave-Core
bbondy added a commit that referenced this pull request Mar 1, 2019
Determine third-party status in Brave-Core
bbondy added a commit that referenced this pull request Mar 1, 2019
Merge pull request #1813 from brave/determine-3p-in-brave-core
bbondy added a commit that referenced this pull request Mar 1, 2019
Merge pull request #1813 from brave/determine-3p-in-brave-core
@mihaiplesa mihaiplesa deleted the determine-3p-in-brave-core branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.