Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows build error caused by "Implement additional ad event confirmations" #1910

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Mar 11, 2019

fixes brave/brave-browser#3672

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@tmancey tmancey added the feature/ads label Mar 11, 2019
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 11, 2019
@tmancey tmancey self-assigned this Mar 11, 2019
@tmancey tmancey force-pushed the issues/3672 branch from abb8089 to 148ac9c Mar 11, 2019
@tmancey tmancey force-pushed the issues/3672 branch from 148ac9c to 2afa978 Mar 11, 2019
@tmancey tmancey marked this pull request as ready for review Mar 12, 2019
@tmancey tmancey requested review from simonhong, yrliou and bbondy Mar 12, 2019
@bbondy
bbondy approved these changes Mar 12, 2019
@tmancey tmancey merged commit 4084a93 into master Mar 12, 2019
@tmancey tmancey deleted the issues/3672 branch Mar 12, 2019
@tmancey tmancey restored the issues/3672 branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.