Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID and Type are now sent with request headers on grant fetch #1911

Merged
merged 1 commit into from Mar 15, 2019
Merged

ID and Type are now sent with request headers on grant fetch #1911

merged 1 commit into from Mar 15, 2019

Conversation

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Mar 12, 2019 •
edited

Resolves brave/brave-browser#3676

This header is required. Will need to be reworked so that it is pulled from RewardsService.
Resolves brave/brave-browser#2873

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

cc @evq @jsecretan
@jasonrsadler jasonrsadler added this to the 0.64.x - Nightly milestone Mar 12, 2019
@jasonrsadler jasonrsadler self-assigned this Mar 12, 2019
@jasonrsadler jasonrsadler requested review from yrliou, ryanml, evq and NejcZdovc Mar 12, 2019
@ryanml
ryanml reviewed Mar 12, 2019
View changes
Copy link
Member

ryanml left a comment

lgtm
@evq
evq reviewed Mar 12, 2019
View changes
Copy link
Member

evq left a comment

++
@yrliou
yrliou reviewed Mar 12, 2019
View changes
Copy link
Member

yrliou left a comment

LGTM
@jasonrsadler jasonrsadler dismissed stale reviews from yrliou, evq, and ryanml via fd4a3c2 Mar 12, 2019
@jasonrsadler jasonrsadler force-pushed the grant-id-type branch 2 times, most recently from 8520549 to 0219ef5 Mar 12, 2019
@jasonrsadler
Copy link
Contributor Author

jasonrsadler commented Mar 12, 2019

Small change:
Removed https://github.com/brave/brave-core/pull/1911/files#diff-e2f16c92804f12e39bedfb61470fe4efL591 for brave/brave-browser#2873
@jasonrsadler jasonrsadler requested review from yrliou, ryanml and evq Mar 12, 2019
@NejcZdovc
NejcZdovc reviewed Mar 13, 2019
View changes
components/brave_rewards/resources/ui/reducers/grant_reducer.ts Outdated Show resolved Hide resolved
@NejcZdovc
NejcZdovc reviewed Mar 13, 2019
View changes
components/brave_rewards/resources/ui/reducers/grant_reducer.ts Outdated Show resolved Hide resolved
@jasonrsadler jasonrsadler requested a review from NejcZdovc Mar 13, 2019
@jasonrsadler jasonrsadler force-pushed the grant-id-type branch from 0219ef5 to 3e5d8ae Mar 13, 2019
Jason Sadler
Resolves brave/brave-browser#3676
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
b09a73a 
Remove Brave specific header

Added check for member vars

Reverting header removal
@jasonrsadler jasonrsadler force-pushed the grant-id-type branch 2 times, most recently from 4cbc1f6 to b09a73a Mar 13, 2019
@ryanml
ryanml approved these changes Mar 13, 2019
View changes
Copy link
Member

ryanml left a comment

++
@evq
evq approved these changes Mar 14, 2019
View changes
Copy link
Member

evq left a comment

++
@jasonrsadler jasonrsadler merged commit 5cdfa47 into master Mar 15, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasonrsadler jasonrsadler deleted the grant-id-type branch Mar 15, 2019
@jasonrsadler jasonrsadler restored the grant-id-type branch Mar 19, 2019
@jasonrsadler jasonrsadler deleted the grant-id-type branch Mar 19, 2019
jasonrsadler pushed a commit that referenced this pull request Mar 19, 2019
Jason Sadler
Merge pull request #1911 from brave/grant-id-type
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
1e35365 
ID and Type are now sent with request headers on grant fetch
@jasonrsadler jasonrsadler mentioned this pull request Mar 19, 2019
Merged
jasonrsadler pushed a commit that referenced this pull request Mar 19, 2019
Jason Sadler
Merge pull request #2007 from brave/grant-id-type-63
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3a33bd1 
Merge pull request #1911 from brave/grant-id-type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml

@evq evq

@yrliou yrliou

@NejcZdovc NejcZdovc

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
  0.64.x - Release
Linked issues

Successfully merging this pull request may close these issues.

Pass id and type for getGrantCaptcha
ledger should not have brave-specific header values
5 participants
@jasonrsadler @yrliou @ryanml @evq @NejcZdovc
You can’t perform that action at this time.