Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows build error caused by "Implement additional ad event confirmations” #1913

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Mar 12, 2019

fixes brave/brave-browser#3679

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@tmancey tmancey changed the title Fixed Windows build error caused by "Implement additional ad event co… Fixed Windows build error caused by "Implement additional ad event confirmations” Mar 12, 2019
@tmancey tmancey requested review from simonhong and bridiver Mar 12, 2019
@tmancey tmancey self-assigned this Mar 12, 2019
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 12, 2019
@tmancey tmancey merged commit 4c67a1e into master Mar 12, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tmancey tmancey deleted the issues/3672 branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.