Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows build error caused by "Implement additional ad event confirmations” 0.63.x Dev #1921

Merged
merged 1 commit into from Mar 13, 2019

Conversation

@tmancey
Copy link
Collaborator

tmancey commented Mar 12, 2019

Fixes brave/brave-browser#3679
Uplift request from #1913

@tmancey tmancey requested review from brave/uplift-approvers and removed request for brave/uplift-approvers Mar 12, 2019
@tmancey tmancey added the PR/Blocked label Mar 12, 2019
@tmancey tmancey added this to the 0.63.x - Dev milestone Mar 12, 2019
@tmancey tmancey force-pushed the issues/3679-0.63.x branch from 33fbb04 to b4b1d9d Mar 12, 2019
@tmancey tmancey added feature/ads and removed PR/Blocked labels Mar 13, 2019
@tmancey tmancey self-assigned this Mar 13, 2019
@tmancey tmancey force-pushed the issues/3679-0.63.x branch from b4b1d9d to 93c7149 Mar 13, 2019
@tmancey tmancey requested a review from bbondy Mar 13, 2019
@tmancey tmancey force-pushed the issues/3679-0.63.x branch from 93c7149 to 3d5320c Mar 13, 2019
@tmancey tmancey force-pushed the issues/3679-0.63.x branch from 3d5320c to 8d73ea6 Mar 13, 2019
@bbondy
bbondy approved these changes Mar 13, 2019
@tmancey tmancey merged commit dd5aff4 into 0.63.x Mar 13, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tmancey tmancey deleted the issues/3679-0.63.x branch Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.