Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Update Stripe Onramp Description #19866

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updates the Stripe onramp Icon and Description

Resolves brave/brave-browser#32226

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Before:

Screenshot 40

After:

Screenshot 37

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner August 24, 2023 21:35
@Douglashdaniel Douglashdaniel self-assigned this Aug 24, 2023
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner August 24, 2023 21:35
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Aug 24, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@Douglashdaniel Douglashdaniel merged commit 02e7515 into master Aug 29, 2023
15 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-update-stripe-onramp-description branch August 29, 2023 16:33
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 29, 2023
Douglashdaniel added a commit that referenced this pull request Aug 29, 2023
…description

fix(wallet): Update Stripe Onramp Description
@srirambv
Copy link
Contributor

srirambv commented Sep 1, 2023

Verification passed on

Brave 1.59.62 Chromium: 116.0.5845.163 (Official Build) nightly (64-bit)
Revision 0018a11
OS Linux
  • Verified steps from PR
  • Verified Stripe Onramp description and image is updated
    Screenshot-20230901120733-1920x1048

kjozwiak pushed a commit that referenced this pull request Sep 3, 2023
)

Merge pull request #19866 from brave/fix-wallet-update-stripe-onramp-description

fix(wallet): Update Stripe Onramp Description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Stripe text description
5 participants