in-page translation #2006

yrliou · 2019-03-19T04:35:41Z

This PR re-enable entries of translate service, all incurred requests will be sent to go-translate server (https://github.com/brave/go-translate) to either be relayed to MS server or be proxied through Brave to avoid introducing direct connections to google.

go-translate is now running locally at localhost:8195 manually, the URL will be updated to a brave server once go-translate is deployed by devops.

Related PR:
brave/go-translate#1

Entry points of translation service

Through the translate bubble in the location bar

Through the context menu

Submitter Checklist:

Test Plan:

Navigate to https://www.deutschland.de/de and click translate when the translate bubble shows up. Continue surfing through this website and pages should be translated.
Open a new tab to navigate to https://www.deutschland.de/de, click "Translate to English" (depends on your local language) in the context menu, current page should be translated, when click away through links in this page, they will not be translated.

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

browser/net/brave_profile_network_delegate.cc

browser/net/brave_translate_redirect_network_delegate_helper.cc

browser/net/brave_static_redirect_network_delegate_helper.cc

emerick

LGTM

app/brave_generated_resources.grd

yrliou · 2019-03-20T20:06:23Z

Updated wording in the bubble title, now looks like this:

browser/net/brave_static_redirect_network_delegate_helper.cc

rebron · 2019-03-20T23:13:18Z

Updated wording in the bubble title, now looks like this:

The language here looks good.

yrliou · 2019-03-21T19:40:06Z

rebased on C74.

jumde · 2019-03-25T18:52:02Z

app/brave_generated_resources.grd

@@ -396,6 +396,10 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
      <message name="IDS_SETTINGS_BRAVE_ON_EXIT" desc="Clear Browsing Data dialog On exit tab label">
        On exit
      </message>
+      <!-- In-page Translation -->
+      <message name="IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE" desc="Title text for the translate bubble when asking to translate a page.">
+        Translate this page? This will send all text on this page to Microsoft for translation.


Do we plan to have a wiki that highlights the text will not be associated with any user identifiable information?

cc: @diracdeltas

not yet; maybe https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs could mention what data is sent in each of the proxied requests

emerick

LGTM


        Enable translate bubble view

Revert "use chromium_src override instead" This reverts commit d872ce8.


        Revert "disable translation service, disable TranslateURLFetcher, hid…

…e associated UI in preferences (#562)" This reverts commit 8eec750.


        Add a new translate icon


        Redirect in-page translation related requests to go-translate


        Rewrite the text in the translate bubble to indicate that texts will …

…be sent to the MS server.


        Add translate request tests for system network delegate


        Add translate request tests for profile network delegate


        fix lint


        Address review comments

1. Fix typo 2. Use constant in system network delegate 3. Use BindRepeating instead of Bind


        Update wording in the translate bubble


        Update brave translate server's address

yrliou · 2019-04-04T05:01:56Z

linux and mac passed: https://staging.ci.brave.com/job/brave-browser-build-pr/job/page-translate/3/flowGraphTable/
windows-x64 passed after widevine PRs reverted: https://staging.ci.brave.com/job/brave-browser-build-pr/job/page-translate/4/flowGraphTable/

@emerick sorry the review is being dismissed again because I have to push again to try windows after reverting widevine PRs, no code changes here, please approve again then I'll merge.

emerick

LGTM

bbondy · 2019-04-05T01:42:38Z

🎉

bsclifton · 2019-04-05T16:40:12Z

Great job with this, @yrliou! And thanks for being vigilant to make CI passes 😄

kmichelizzi · 2019-06-06T22:18:15Z

Sorry, this is not working on MacOS 10.14.5 going to www.yandex.ru - it never shows the translate bubble. Doesn't have Translate in the context menu either. Neither does going to the specified verification webpage (deutschland.de/de) - if it is going to be difficult to enable, it isn't working in my book. This is with Brave Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit).

yrliou · 2019-06-06T22:31:12Z

@kmichelizzi Translation service is disabled on Release channel currently due to cost performance, we're still working on enabling it on Release channel.
In the mean time it is enabled on Nightly, Dev, and Beta. which you could grab and install if you would like to use the translation service for now.

kmichelizzi · 2019-06-06T22:42:15Z

Thanks, @yrliou - the Nightly, Dev, and Beta don't run on MacOS 10.14.5. All 3 versions just spin until crash on loading.
Brave Browser Beta [23658] crash report.txt

yrliou · 2019-06-06T22:53:10Z

@kmichelizzi I'm also on MacOS 10.14.5, Nightly, Dev, and Beta all works fine for me.
You might need to create a new issue in https://github.com/brave/brave-browser with details in that case so we could help identify what's the problem, thanks.

yrliou self-assigned this Mar 19, 2019

yrliou changed the title ~~[WIP] in-page translate~~ WIP: in-page translate Mar 19, 2019

yrliou force-pushed the page-translate branch 3 times, most recently from f07daee to 5f54528 Mar 19, 2019

yrliou changed the title ~~WIP: in-page translate~~ WIP: in-page translation Mar 19, 2019

yrliou added this to the 0.64.x - Nightly milestone Mar 19, 2019

yrliou force-pushed the page-translate branch 3 times, most recently from dd87208 to c456ea9 Mar 20, 2019

yrliou marked this pull request as ready for review Mar 20, 2019

yrliou requested a review from bbondy Mar 20, 2019

yrliou changed the title ~~WIP: in-page translation~~ in-page translation Mar 20, 2019

yrliou requested review from emerick and mkarolin Mar 20, 2019

emerick reviewed Mar 20, 2019

View changes

browser/net/brave_profile_network_delegate.cc Outdated Show resolved Hide resolved

browser/net/brave_translate_redirect_network_delegate_helper.cc Outdated Show resolved Hide resolved

browser/net/brave_static_redirect_network_delegate_helper.cc Outdated Show resolved Hide resolved

jumde reviewed Mar 20, 2019

View changes

browser/net/brave_static_redirect_network_delegate_helper.cc Show resolved Hide resolved

emerick reviewed Mar 20, 2019

View changes

yrliou dismissed emerick’s stale review via c4ab387 Mar 20, 2019

diracdeltas reviewed Mar 20, 2019

View changes

app/brave_generated_resources.grd Outdated Show resolved Hide resolved

diracdeltas reviewed Mar 20, 2019

View changes

browser/net/brave_static_redirect_network_delegate_helper.cc Outdated Show resolved Hide resolved

yrliou force-pushed the page-translate branch from c4ab387 to e233946 Mar 21, 2019

jumde reviewed Mar 25, 2019

View changes

jumde self-requested a review Mar 25, 2019

jumde reviewed Mar 25, 2019

View changes

yrliou dismissed jumde’s stale review via f241907 Apr 3, 2019

yrliou force-pushed the page-translate branch from e233946 to f241907 Apr 3, 2019

yrliou added this to the 0.65.x - Nightly milestone Apr 3, 2019

yrliou force-pushed the page-translate branch from f241907 to 989c0dc Apr 3, 2019

yrliou requested a review from emerick Apr 4, 2019

emerick reviewed Apr 4, 2019

View changes

yrliou added 11 commits Feb 5, 2019

Enable translate bubble view

d37f049

Revert "use chromium_src override instead" This reverts commit d872ce8.

Revert "disable translation service, disable TranslateURLFetcher, hid…

15d2fd6

…e associated UI in preferences (#562)" This reverts commit 8eec750.

Add a new translate icon

0cfeb33

Redirect in-page translation related requests to go-translate

06a4213

Rewrite the text in the translate bubble to indicate that texts will …

3b01cbf

…be sent to the MS server.

Add translate request tests for system network delegate

e942131

Add translate request tests for profile network delegate

4f6a88c

fix lint

0add959

Address review comments

32c07ef

1. Fix typo 2. Use constant in system network delegate 3. Use BindRepeating instead of Bind

Update wording in the translate bubble

919f95a

Update brave translate server's address

Loading status checks…

82e4e29

yrliou dismissed emerick’s stale review via 82e4e29 Apr 4, 2019

yrliou force-pushed the page-translate branch from 989c0dc to 82e4e29 Apr 4, 2019

yrliou requested a review from emerick Apr 4, 2019

emerick approved these changes Apr 4, 2019

View changes

yrliou merged commit 4c18291 into master Apr 4, 2019
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

bsclifton deleted the page-translate branch Apr 5, 2019

LaurenWags mentioned this pull request May 21, 2019

In page translation for content #208

Closed

brave / brave-core

in-page translation #2006

in-page translation #2006

yrliou commented Mar 19, 2019 •

edited

emerick left a comment

yrliou commented Mar 20, 2019

rebron commented Mar 20, 2019

yrliou commented Mar 21, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

emerick left a comment

yrliou commented Apr 4, 2019

emerick left a comment

bbondy commented Apr 5, 2019

bsclifton commented Apr 5, 2019

kmichelizzi commented Jun 6, 2019

yrliou commented Jun 6, 2019

kmichelizzi commented Jun 6, 2019

yrliou commented Jun 6, 2019

brave / brave-core

Join GitHub today

in-page translation #2006

in-page translation #2006

Conversation

yrliou commented Mar 19, 2019 • edited

Submitter Checklist:

Test Plan:

Reviewer Checklist:

emerick left a comment

yrliou commented Mar 20, 2019

rebron commented Mar 20, 2019

yrliou commented Mar 21, 2019

This comment has been minimized.

jumde Mar 25, 2019

This comment has been minimized.

jumde Mar 25, 2019

This comment has been minimized.

diracdeltas Mar 25, 2019

emerick left a comment

yrliou commented Apr 4, 2019

emerick left a comment

bbondy commented Apr 5, 2019

bsclifton commented Apr 5, 2019

kmichelizzi commented Jun 6, 2019

yrliou commented Jun 6, 2019

kmichelizzi commented Jun 6, 2019

yrliou commented Jun 6, 2019

yrliou commented Mar 19, 2019 •

edited