Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1911 from brave/grant-id-type #2007

Merged
merged 1 commit into from Mar 19, 2019
Merged

Merge pull request #1911 from brave/grant-id-type #2007

merged 1 commit into from Mar 19, 2019

Conversation

@jasonrsadler
Copy link
Contributor

jasonrsadler commented Mar 19, 2019 •
edited by NejcZdovc

Uplift to 0.63.x

Original PR #1911

Resolves brave/brave-browser#3676
Jason Sadler
Merge pull request #1911 from brave/grant-id-type
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
1e35365 
ID and Type are now sent with request headers on grant fetch
@jasonrsadler jasonrsadler added this to the 0.63.x - Dev milestone Mar 19, 2019
@jasonrsadler jasonrsadler self-assigned this Mar 19, 2019
@jasonrsadler jasonrsadler requested review from bbondy, yrliou, ryanml and NejcZdovc Mar 19, 2019
@NejcZdovc NejcZdovc requested review from brave/uplift-approvers and removed request for bbondy, yrliou, ryanml and NejcZdovc Mar 19, 2019
@kjozwiak
kjozwiak approved these changes Mar 19, 2019
View changes
Copy link
Member

kjozwiak left a comment •
edited

Uplift to 0.63.x approved as per our group discussion during the b-c triage call. Also deliberated with @brave/uplift-approvers. Please ensure that all the correct labels are added and that all the associated issues are moved into the correct milestone.

Please make sure that the jenkins failure isn't a direct result of this specific PR.
@jasonrsadler jasonrsadler merged commit 3a33bd1 into 0.63.x Mar 19, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jasonrsadler jasonrsadler deleted the grant-id-type-63 branch Mar 19, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@mihaiplesa
Merge pull request #2007 from hcaw/patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cdfed96 
Fix incorrect name of .list file for dev ubuntu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
  0.63.x - Release
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jasonrsadler @kjozwiak
You can’t perform that action at this time.