New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave syncer #2010
Merged
Do not send meta info until all platforms support necessary chromium
42c5c31
Select commit
c423779
Make browser_sync::ProfileSyncService a brave_sync::SyncMessageHandler
darkdh d08cd5e
Upgrade to 74.0.3729.75
darkdh 5d9fd40
Fixed build on Linux
AlexeyBarabash 5371a9b
Pass icon data
AlexeyBarabash e7155d4
Migrate from legacy sync
darkdh 2b431d6
Introduce IsFirstLoadedFavicon to avoid favicon loading trigged sendi…
darkdh 22e770b
Remove unused code
darkdh be43397
Fix Reset bug and prevent shutdown sync thread hanging
darkdh 78e0d85
Implement OnSaveBookmarkOrder from #2326
darkdh 372552b
Redefine order calculation to be simply parent_order + index_in_parent
darkdh 8896428
Fix wrong sync code crash
darkdh 8ca0675
Subclass browser_sync::ProfileSyncService
darkdh 4972a86
Fix DCHECK failure because of lacking permanent nodes order when
darkdh 6463250
Handle same index from different devices by order
darkdh 05731ec
Set user-chosen sync type only when first time sync setup or migrated
darkdh 4f6ed56
Using MigratedBookmarksVersion >= 2 to check legacy sync migration st…
darkdh 73627bb
Stub out Control Types
darkdh 2d4662f
Fix index calculation when applying remote records
darkdh 5d4d8c2
Migrate BraveSyncServiceTest
darkdh 57cf686
Add test for SyncerHelper
darkdh ed60929
Dont send bookmarks until chain is created. Re-do of brave-core pr#2016
AlexeyBarabash a766cdd
C75.0.3770.38 Upgrade
darkdh 6e31e37
Force DEVICE_INFO to have nudge cycles
AlexeyBarabash 1db950a
Register brave_sync pref with chromium sync
darkdh bd689d0
Consolidate BraveSyncServiceTest
darkdh c5fbe1f
Remove manually disable field trail feature
darkdh 5b0f830
lint fix
darkdh 1e55ab6
Android build fix
darkdh a524251
Move BraveSyncClient to BraveProfileSyncService
darkdh e2617dc
Replace brave_sync::BraveSyncService::is_enabled() with switches::IsB…
darkdh bf1becb
Window release build deps fix
darkdh 902017f
single dep encapsulation
darkdh 2b2e2e5
IsSyncAllowedByFlag chromium_src override
darkdh baf9003
remove GetAsBraveProfileSyncServiceForProfile and use ENABLE_BRAVE_SY…
darkdh 5591700
friend BraveProfileSyncService
darkdh 23fdeed
Using SyncEngineHost to avoid storing poll/nudge delegates
darkdh 0ff789f
Move brave_sync::RegisterProfilePrefs to brave::RegisterProfilePrefs
darkdh d970cad
Chromium override SyncerProtoUtil
darkdh 38b42cf
Update 75.0.3770.90 patch
darkdh 48d6aaf
clean up patches
darkdh f3f381c
add guards for ENABLE_BRAVE_SYNC
bridiver f4a013b
Fixed Linux build
AlexeyBarabash 60d93e0
BraveProfileSyncService => BraveProfileSyncServiceImpl; BraveProfileS…
AlexeyBarabash 3fbacc7
Ignore records from ourselves
AlexeyBarabash 2176464
Send records after at least 30 sec after chain creation
AlexeyBarabash b0c8c49
Fix tests for send records after at least 30 sec after chain creation
AlexeyBarabash ee2fbf5
Patches for attach/detach behaviour for WriteTransaction
AlexeyBarabash 0aad976
Sort bookmarks in BookmarkChangeProcessor::ApplyChangesFromSyncModel …
AlexeyBarabash eb2dd0b
Update DEPS to contain "Ignore records from SQS which where seen in S3"
AlexeyBarabash 5eecbd2
Use title or customeTitle, non empty value
AlexeyBarabash a04cb32
Fix for crash with bookmark position from older sync client (android)
AlexeyBarabash 0f79073
Update 76.0.3809.62 patches
darkdh 1338103
Remove BRAVE_SHOULD_SHOW_SIGNIN_PROMO_SHORT_CIRCUIT_TO_FALSE and lint…
darkdh 7fcee9d
Fix enable_brave_sync=false
darkdh c3fc745
Check DISABLE_REASON_ENTERPRISE_POLICY in ShouldShowSignInPromo and f…
darkdh 97d0eca
Passive resend unconfirmed records
darkdh 4b2b835
Native code for bookmark order calculations
AlexeyBarabash 1c2ba0a
Testcases for native bookmark order calculations
AlexeyBarabash 91e5d05
Sync reset reenable (#3038)
darkdh 9677876
Exponentials resend periods (#2986)
darkdh 412e408
Bookmarks positioning by order strings
AlexeyBarabash e1104e2
Updated testcases for positioning by orders
AlexeyBarabash 5cab8ba
In case of equal orders use object_id
AlexeyBarabash 4969766
Test case for use object_id when orders are equal
AlexeyBarabash 6eef9c2
Ignore move events during extensive changes
AlexeyBarabash 6636c1d
Network changes and Reset handling
darkdh b376e3f
Using UniquePosition for bookmark order by position_in_parent
darkdh ce62ff9
Maintain SyncEntityInfo in bookmark node's meta info for legacy sync
darkdh 99b97f5
Review Feedback (1)
darkdh 220d604
Review Feedback (2)
darkdh 99f29b6
Use WaitableEvent::TimedWait as fail-safe
darkdh 8b24310
Review feedback (3)
darkdh 42c5c31
Do not send meta info until all platforms support necessary chromium
darkdh
Merged
Brave syncer #2010
Do not send meta info until all platforms support necessary chromium
Feb 26, 2019
Apr 11, 2019
Apr 12, 2019
Apr 18, 2019
Apr 18, 2019
Apr 20, 2019
Apr 22, 2019
Apr 23, 2019
Apr 25, 2019
Apr 26, 2019
Apr 30, 2019
May 6, 2019
May 7, 2019
May 7, 2019
May 9, 2019
May 9, 2019
May 10, 2019
May 13, 2019
May 16, 2019
May 17, 2019
May 20, 2019
May 21, 2019
May 24, 2019
May 24, 2019
May 24, 2019
May 28, 2019
May 28, 2019
May 29, 2019
May 29, 2019
May 29, 2019
May 31, 2019
Jun 12, 2019
Jun 12, 2019
Jun 12, 2019
Jun 12, 2019
Jun 13, 2019
Jun 13, 2019
Jun 16, 2019
Jun 18, 2019
Jun 19, 2019
Jun 19, 2019
Jun 20, 2019
Jun 25, 2019
Jun 25, 2019
Jun 25, 2019
Jun 25, 2019
Jun 25, 2019
Jun 25, 2019
Jun 25, 2019
Jul 1, 2019
Jul 9, 2019
Jul 15, 2019
Jul 16, 2019
Jul 17, 2019
Jul 17, 2019
Jul 23, 2019
Jul 24, 2019
Jul 24, 2019
Jul 31, 2019
Aug 8, 2019
Jul 24, 2019
Jul 24, 2019
Aug 6, 2019
Aug 6, 2019
Aug 6, 2019
Aug 13, 2019
Aug 14, 2019
Aug 15, 2019
Aug 16, 2019
Aug 16, 2019
Aug 16, 2019
Aug 17, 2019
Aug 19, 2019
42c5c31
Select commit
c423779
Make browser_sync::ProfileSyncService a brave_sync::SyncMessageHandler
darkdh d08cd5e
Upgrade to 74.0.3729.75
darkdh 5d9fd40
Fixed build on Linux
AlexeyBarabash 5371a9b
Pass icon data
AlexeyBarabash e7155d4
Migrate from legacy sync
darkdh 2b431d6
Introduce IsFirstLoadedFavicon to avoid favicon loading trigged sendi…
darkdh 22e770b
Remove unused code
darkdh be43397
Fix Reset bug and prevent shutdown sync thread hanging
darkdh 78e0d85
Implement OnSaveBookmarkOrder from #2326
darkdh 372552b
Redefine order calculation to be simply parent_order + index_in_parent
darkdh 8896428
Fix wrong sync code crash
darkdh 8ca0675
Subclass browser_sync::ProfileSyncService
darkdh 4972a86
Fix DCHECK failure because of lacking permanent nodes order when
darkdh 6463250
Handle same index from different devices by order
darkdh 05731ec
Set user-chosen sync type only when first time sync setup or migrated
darkdh 4f6ed56
Using MigratedBookmarksVersion >= 2 to check legacy sync migration st…
darkdh 73627bb
Stub out Control Types
darkdh 2d4662f
Fix index calculation when applying remote records
darkdh 5d4d8c2
Migrate BraveSyncServiceTest
darkdh 57cf686
Add test for SyncerHelper
darkdh ed60929
Dont send bookmarks until chain is created. Re-do of brave-core pr#2016
AlexeyBarabash a766cdd
C75.0.3770.38 Upgrade
darkdh 6e31e37
Force DEVICE_INFO to have nudge cycles
AlexeyBarabash 1db950a
Register brave_sync pref with chromium sync
darkdh bd689d0
Consolidate BraveSyncServiceTest
darkdh c5fbe1f
Remove manually disable field trail feature
darkdh 5b0f830
lint fix
darkdh 1e55ab6
Android build fix
darkdh a524251
Move BraveSyncClient to BraveProfileSyncService
darkdh e2617dc
Replace brave_sync::BraveSyncService::is_enabled() with switches::IsB…
darkdh bf1becb
Window release build deps fix
darkdh 902017f
single dep encapsulation
darkdh 2b2e2e5
IsSyncAllowedByFlag chromium_src override
darkdh baf9003
remove GetAsBraveProfileSyncServiceForProfile and use ENABLE_BRAVE_SY…
darkdh 5591700
friend BraveProfileSyncService
darkdh 23fdeed
Using SyncEngineHost to avoid storing poll/nudge delegates
darkdh 0ff789f
Move brave_sync::RegisterProfilePrefs to brave::RegisterProfilePrefs
darkdh d970cad
Chromium override SyncerProtoUtil
darkdh 38b42cf
Update 75.0.3770.90 patch
darkdh 48d6aaf
clean up patches
darkdh f3f381c
add guards for ENABLE_BRAVE_SYNC
bridiver f4a013b
Fixed Linux build
AlexeyBarabash 60d93e0
BraveProfileSyncService => BraveProfileSyncServiceImpl; BraveProfileS…
AlexeyBarabash 3fbacc7
Ignore records from ourselves
AlexeyBarabash 2176464
Send records after at least 30 sec after chain creation
AlexeyBarabash b0c8c49
Fix tests for send records after at least 30 sec after chain creation
AlexeyBarabash ee2fbf5
Patches for attach/detach behaviour for WriteTransaction
AlexeyBarabash 0aad976
Sort bookmarks in BookmarkChangeProcessor::ApplyChangesFromSyncModel …
AlexeyBarabash eb2dd0b
Update DEPS to contain "Ignore records from SQS which where seen in S3"
AlexeyBarabash 5eecbd2
Use title or customeTitle, non empty value
AlexeyBarabash a04cb32
Fix for crash with bookmark position from older sync client (android)
AlexeyBarabash 0f79073
Update 76.0.3809.62 patches
darkdh 1338103
Remove BRAVE_SHOULD_SHOW_SIGNIN_PROMO_SHORT_CIRCUIT_TO_FALSE and lint…
darkdh 7fcee9d
Fix enable_brave_sync=false
darkdh c3fc745
Check DISABLE_REASON_ENTERPRISE_POLICY in ShouldShowSignInPromo and f…
darkdh 97d0eca
Passive resend unconfirmed records
darkdh 4b2b835
Native code for bookmark order calculations
AlexeyBarabash 1c2ba0a
Testcases for native bookmark order calculations
AlexeyBarabash 91e5d05
Sync reset reenable (#3038)
darkdh 9677876
Exponentials resend periods (#2986)
darkdh 412e408
Bookmarks positioning by order strings
AlexeyBarabash e1104e2
Updated testcases for positioning by orders
AlexeyBarabash 5cab8ba
In case of equal orders use object_id
AlexeyBarabash 4969766
Test case for use object_id when orders are equal
AlexeyBarabash 6eef9c2
Ignore move events during extensive changes
AlexeyBarabash 6636c1d
Network changes and Reset handling
darkdh b376e3f
Using UniquePosition for bookmark order by position_in_parent
darkdh ce62ff9
Maintain SyncEntityInfo in bookmark node's meta info for legacy sync
darkdh 99b97f5
Review Feedback (1)
darkdh 220d604
Review Feedback (2)
darkdh 99f29b6
Use WaitableEvent::TimedWait as fail-safe
darkdh 8b24310
Review feedback (3)
darkdh 42c5c31
Do not send meta info until all platforms support necessary chromium
darkdh