New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave syncer #2010
Brave syncer #2010
-
Make browser_sync::ProfileSyncService a brave_sync::SyncMessageHandler
darkdh committedFeb 26, 2019 subclass of syncer::SyncClient should own brave_sync::BraveSyncClient* and implement GetBraveSyncClient Update brave sync extension api Suppress BraveSyncServiceImpl create sync chain Start sync engine based on brave_sync enabled Dispatch OnPollSyncCycle and OnNudgeSyncCycle from sync thread to UI thread Avoid use_transport_only_mode and put poll/nudge delegate into syncer fake sync_pb::GetUpdateResponse Adding BookmarksSpecifics Put back Device record & overrides short/long poll interval Add GetRecords callback to PollSyncCycleDelegate Fix OnGetRecords callback triggered on the wrong thread Apply real records from sync chain Get rid of sync event observer for nudge/poll delegate also partial brave commit builder Complete brave commit & update (CREATE, DELETE, partial UPDATE) Add MetaInfo to Bookmark protobuf
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Apr 11, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Apr 18, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Introduce IsFirstLoadedFavicon to avoid favicon loading trigged sendi…
darkdh committedApr 20, 2019 …ng duplicate records
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Apr 22, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Fix Reset bug and prevent shutdown sync thread hanging
darkdh committedApr 23, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Implement OnSaveBookmarkOrder from #2326
darkdh committedApr 25, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Redefine order calculation to be simply parent_order + index_in_parent
darkdh committedApr 26, 2019 deprecate all the logic through brave/sync for getting order
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Apr 30, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Subclass browser_sync::ProfileSyncService
darkdh committedMay 6, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Fix DCHECK failure because of lacking permanent nodes order when
darkdh committedMay 7, 2019 launching from legacy sync profile
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Handle same index from different devices by order
darkdh committedMay 7, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Set user-chosen sync type only when first time sync setup or migrated
darkdh committedMay 9, 2019 from legacy sync. Otherwise, previous sync type will be purged.
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Using MigratedBookmarksVersion >= 2 to check legacy sync migration st…
darkdh committedMay 9, 2019 …atus so that sync engine only starts after OnSyncReady
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
May 10, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Fix index calculation when applying remote records
darkdh committedMay 13, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
May 16, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
May 17, 2019 also 1. remove unecessary const_cast 2. fix empty order bug in ReCalculateOrder 3. add ScopedPauseObserver to reduce patch
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
May 21, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Register brave_sync pref with chromium sync
darkdh committedMay 24, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Consolidate BraveSyncServiceTest
darkdh committedMay 24, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Remove manually disable field trail feature
darkdh committedMay 28, 2019 Make sure brave/brave-browser#4551 and #2471 landed first
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Move BraveSyncClient to BraveProfileSyncService
darkdh committedMay 29, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Replace brave_sync::BraveSyncService::is_enabled() with switches::IsB…
darkdh committedMay 29, 2019 …raveSyncAllowedByFlag()
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
May 31, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Jun 12, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
IsSyncAllowedByFlag chromium_src override
darkdh committedJun 12, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
remove GetAsBraveProfileSyncServiceForProfile and use ENABLE_BRAVE_SY…
darkdh committedJun 12, 2019 …NC in chromium
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
friend BraveProfileSyncService
darkdh committedJun 12, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Using SyncEngineHost to avoid storing poll/nudge delegates
darkdh committedJun 13, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Move brave_sync::RegisterProfilePrefs to brave::RegisterProfilePrefs
darkdh committedJun 13, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Chromium override SyncerProtoUtil
darkdh committedJun 16, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Jun 18, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Jun 19, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
BraveProfileSyncService => BraveProfileSyncServiceImpl; BraveProfileS…
…yncServiceExports => BraveProfileSyncService
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Sort bookmarks in BookmarkChangeProcessor::ApplyChangesFromSyncModel …
…and update corresponding sync nodes
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Jul 15, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Remove BRAVE_SHOULD_SHOW_SIGNIN_PROMO_SHORT_CIRCUIT_TO_FALSE and lint…
darkdh committedJul 16, 2019 … fix
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Check DISABLE_REASON_ENTERPRISE_POLICY in ShouldShowSignInPromo and f…
darkdh committedJul 17, 2019 …ix GetDisableReasons unittest
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Passive resend unconfirmed records
darkdh committedJul 23, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Native code for bookmark order calculations
Improved processing of GetOrder('2.5.6.3', '2.5.7.8.2') Simplified GetOrderVerified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Testcases for native bookmark order calculations
Test for improved processing of GetOrder('2.5.6.3', '2.5.7.8.2') Updated and expanded tests for simplified GetOrderVerified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Jul 31, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Exponentials resend periods (#2986)
darkdh committedAug 8, 2019 Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Network changes and Reset handling
darkdh committedAug 13, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Using UniquePosition for bookmark order by position_in_parent
darkdh committedAug 14, 2019 1. legacy order will still be sent for compatibility 2. legacy order will be used when there is no position_in_parent (legacy sync) during applying remote changes
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Maintain SyncEntityInfo in bookmark node's meta info for legacy sync
darkdh committedAug 15, 2019 compatibility
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Aug 16, 2019 1. Remvoe weak_ptr for syncer and make sure get_record_cb_ won't get called when sync_thread is not running 2. Remove unnecessary forward declaration
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Use WaitableEvent::TimedWait as fail-safe
darkdh committedAug 16, 2019 Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
darkdh committed
Aug 17, 2019 1. Generate fake NIGORI entity when apply update 2. Set dummy encryption key for every update_response
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits -
Do not send meta info until all platforms support necessary chromium
sync protocol like "version" and "UniquePosition", ...etc
Verified
This commit was signed with a verified signature.darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits