Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave syncer #2010

Merged
merged 73 commits into from Aug 20, 2019
Merged

Brave syncer #2010

merged 73 commits into from Aug 20, 2019
Commits on Aug 19, 2019
  1. Make browser_sync::ProfileSyncService a brave_sync::SyncMessageHandler

    darkdh committed Feb 26, 2019
    subclass of syncer::SyncClient should own brave_sync::BraveSyncClient* and implement GetBraveSyncClient
    
    Update brave sync extension api
    
    Suppress BraveSyncServiceImpl
    
    create sync chain
    
    Start sync engine based on brave_sync enabled
    
    Dispatch OnPollSyncCycle and OnNudgeSyncCycle from sync thread to UI thread
    
    Avoid use_transport_only_mode and put poll/nudge delegate into syncer
    
    fake sync_pb::GetUpdateResponse
    
    Adding BookmarksSpecifics
    
    Put back Device record & overrides short/long poll interval
    
    Add GetRecords callback to PollSyncCycleDelegate
    
    Fix OnGetRecords callback triggered on the wrong thread
    
    Apply real records from sync chain
    
    Get rid of sync event observer for nudge/poll delegate
    also partial brave commit builder
    
    Complete brave commit & update (CREATE, DELETE, partial UPDATE)
    Add MetaInfo to Bookmark protobuf
  2. Upgrade to 74.0.3729.75

    darkdh committed Apr 11, 2019
  3. Fixed build on Linux

    AlexeyBarabash authored and darkdh committed Apr 12, 2019
  4. Pass icon data

    AlexeyBarabash authored and darkdh committed Apr 18, 2019
  5. Migrate from legacy sync

    darkdh committed Apr 18, 2019
  6. Introduce IsFirstLoadedFavicon to avoid favicon loading trigged sendi…

    darkdh committed Apr 20, 2019
    …ng duplicate records
  7. Remove unused code

    darkdh committed Apr 22, 2019
  8. Redefine order calculation to be simply parent_order + index_in_parent

    darkdh committed Apr 26, 2019
    deprecate all the logic through brave/sync for getting order
  9. Fix wrong sync code crash

    darkdh committed Apr 30, 2019
  10. Fix DCHECK failure because of lacking permanent nodes order when

    darkdh committed May 7, 2019
    launching from legacy sync profile
  11. Set user-chosen sync type only when first time sync setup or migrated

    darkdh committed May 9, 2019
    from legacy sync. Otherwise, previous sync type will be purged.
  12. Using MigratedBookmarksVersion >= 2 to check legacy sync migration st…

    darkdh committed May 9, 2019
    …atus so
    
    that sync engine only starts after OnSyncReady
  13. Stub out Control Types

    darkdh committed May 10, 2019
  14. Migrate BraveSyncServiceTest

    darkdh committed May 16, 2019
  15. Add test for SyncerHelper

    darkdh committed May 17, 2019
    also
    1. remove unecessary const_cast
    2. fix empty order bug in ReCalculateOrder
    3. add ScopedPauseObserver to reduce patch
  16. C75.0.3770.38 Upgrade

    darkdh committed May 21, 2019
  17. Remove manually disable field trail feature

    darkdh committed May 28, 2019
    Make sure brave/brave-browser#4551 and
    #2471 landed first
  18. lint fix

    darkdh committed May 28, 2019
  19. Android build fix

    darkdh committed May 29, 2019
    brave_sync deps fix
  20. Replace brave_sync::BraveSyncService::is_enabled() with switches::IsB…

    darkdh committed May 29, 2019
    …raveSyncAllowedByFlag()
  21. Window release build deps fix

    darkdh committed May 31, 2019
  22. single dep encapsulation

    darkdh committed Jun 12, 2019
  23. friend BraveProfileSyncService

    darkdh committed Jun 12, 2019
  24. Update 75.0.3770.90 patch

    darkdh committed Jun 18, 2019
  25. clean up patches

    darkdh committed Jun 19, 2019
  26. add guards for ENABLE_BRAVE_SYNC

    bridiver authored and darkdh committed Jun 19, 2019
  27. Fixed Linux build

    AlexeyBarabash authored and darkdh committed Jun 20, 2019
  28. BraveProfileSyncService => BraveProfileSyncServiceImpl; BraveProfileS…

    AlexeyBarabash authored and darkdh committed Jun 25, 2019
    …yncServiceExports => BraveProfileSyncService
  29. Ignore records from ourselves

    AlexeyBarabash authored and darkdh committed Jun 25, 2019
  30. Sort bookmarks in BookmarkChangeProcessor::ApplyChangesFromSyncModel …

    AlexeyBarabash authored and darkdh committed Jun 25, 2019
    …and update corresponding sync nodes
  31. Update 76.0.3809.62 patches

    darkdh committed Jul 15, 2019
  32. Fix enable_brave_sync=false

    darkdh committed Jul 17, 2019
    Remove unused code
  33. Check DISABLE_REASON_ENTERPRISE_POLICY in ShouldShowSignInPromo and f…

    darkdh committed Jul 17, 2019
    …ix GetDisableReasons unittest
  34. Native code for bookmark order calculations

    AlexeyBarabash authored and darkdh committed Jul 24, 2019
    Improved processing of GetOrder('2.5.6.3', '2.5.7.8.2')
    
    Simplified GetOrder
  35. Testcases for native bookmark order calculations

    AlexeyBarabash authored and darkdh committed Jul 24, 2019
    Test for improved processing of GetOrder('2.5.6.3', '2.5.7.8.2')
    
    Updated and expanded tests for simplified GetOrder
  36. Sync reset reenable (#3038)

    darkdh committed Jul 31, 2019
  37. Exponentials resend periods (#2986)

    darkdh committed Aug 8, 2019
    Resend meta shouldn't use metainfo from node (delete record doesn't have a node)
  38. Using UniquePosition for bookmark order by position_in_parent

    darkdh committed Aug 14, 2019
    1. legacy order will still be sent for compatibility
    2. legacy order will be used when there is no position_in_parent (legacy sync)
      during applying remote changes
  39. Review Feedback (1)

    darkdh committed Aug 16, 2019
    1. Patch standardization
    2. Apply clang-format
  40. Review Feedback (2)

    darkdh committed Aug 16, 2019
      1. Remvoe weak_ptr for syncer and make sure get_record_cb_ won't get
      called when sync_thread is not running
      2. Remove unnecessary forward declaration
  41. Review feedback (3)

    darkdh committed Aug 17, 2019
    1. Generate fake NIGORI entity when apply update
    2. Set dummy encryption key for every update_response
  42. Do not send meta info until all platforms support necessary chromium

    darkdh committed Aug 19, 2019
    sync protocol like "version" and "UniquePosition", ...etc
You can’t perform that action at this time.