Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix french translation typo on BAT contribution popup #2099
Conversation
|
Seems like I cannot tag reviewers. Maybe @petemill ? |
cndouglas left a comment
|
Thanks for the improvements! Instead of changing the translation files directly, please change the translations on Transifex: https://www.transifex.com/brave/brave/. These translation files are overwritten when the translations are imported from Transifex. |
|
Thanks for the assist, @Liunkae! @fakenine as called out by @Liunkae, you'll want to sign up for transifex and then we can add you as a contributor (feel free to post here once you've signed up and we can get your permissions sorted) We pull translations from transifex on an ad-hoc basis and overwrite the files in the repo with what's in transifex cc: @atsyed87 who might be able to help you with permissions |
|
Hello @bsclifton, Thank you for the precisions |
atsyed87
commented
Apr 4, 2019
|
Hey @fakenine, I added you to our Transifex. Let me know if you have any problems! |
|
Hello @atsyed87, Thank you! I'm having issues accessing the translation page of Transifex. The items do not load and I'm having 403 errors in the console. |

fakenine commentedMar 27, 2019
•
edited
fixes brave/brave-browser#3913
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: