Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix french translation typo on BAT contribution popup #2099

Closed
wants to merge 1 commit into from

Conversation

@fakenine
Copy link

fakenine commented Mar 27, 2019

fixes brave/brave-browser#3913

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Open Brave with French set as a language
  2. Click on the "Brave Rewards" logo
  3. Click on "Envoyer une contribution"

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
@fakenine
Copy link
Author

fakenine commented Mar 28, 2019

Seems like I cannot tag reviewers. Maybe @petemill ?

Copy link

cndouglas left a comment

Thanks for the improvements! Instead of changing the translation files directly, please change the translations on Transifex: https://www.transifex.com/brave/brave/. These translation files are overwritten when the translations are imported from Transifex.

@bsclifton
Copy link
Member

bsclifton commented Mar 29, 2019

Thanks for the assist, @Liunkae!

@fakenine as called out by @Liunkae, you'll want to sign up for transifex and then we can add you as a contributor (feel free to post here once you've signed up and we can get your permissions sorted)

We pull translations from transifex on an ad-hoc basis and overwrite the files in the repo with what's in transifex 😄 I'll close this PR, but your work is definitely welcomed!

cc: @atsyed87 who might be able to help you with permissions 😄

@bsclifton bsclifton closed this Mar 29, 2019
@fakenine
Copy link
Author

fakenine commented Apr 4, 2019

Hello @bsclifton,

Thank you for the precisions 😄
My Transifex account can be found here : https://www.transifex.com/user/profile/fakenine/, I have submitted a request to join the team cc @atsyed87

@fakenine fakenine deleted the fakenine:fix_french_translation_on_bat_contribution_modal branch Apr 4, 2019
@atsyed87
Copy link

atsyed87 commented Apr 4, 2019

Hey @fakenine, I added you to our Transifex. Let me know if you have any problems!

@fakenine
Copy link
Author

fakenine commented Apr 10, 2019

Hello @atsyed87,

Thank you!

I'm having issues accessing the translation page of Transifex. The items do not load and I'm having 403 errors in the console.

Capture d’écran de 2019-04-10 20-01-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.