Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BraveDarkModeObserver test run only on MacOS #2174

Merged
merged 1 commit into from Apr 6, 2019

Conversation

@simonhong
Copy link
Collaborator

simonhong commented Apr 6, 2019

We don't change native theme by changing brave theme on non macOS.

Fix brave/brave-browser#4037

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source
We don't change native theme by changing brave theme on non macOS.
@simonhong simonhong added this to the 0.65.x - Nightly milestone Apr 6, 2019
@simonhong simonhong self-assigned this Apr 6, 2019
@simonhong simonhong requested a review from petemill Apr 6, 2019
@simonhong simonhong marked this pull request as ready for review Apr 6, 2019
Copy link
Member

petemill left a comment

😓

@petemill petemill merged commit f7e1262 into master Apr 6, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@petemill petemill deleted the fix_dark_mode_observer_test branch Apr 6, 2019
simonhong added a commit that referenced this pull request Apr 6, 2019
Make BraveDarkModeObserver test run only on MacOS
simonhong added a commit that referenced this pull request Apr 6, 2019
Make BraveDarkModeObserver test run only on MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.