Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed string for sync on device with wrong time #2191
Merged
Conversation
479c6cb
to
4f54900
This was referenced Apr 15, 2019
b861a36
to
12943bf
|
@brave/uplift-approvers , @bradleyrichter , @tomlowenthal CI finally succeeded, so could please you review it? |
|
The only thing I'd be reviewing is a text match. So that lg2m. |
|
Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


AlexeyBarabash commentedApr 10, 2019
•
edited
This is fix according the comment #2155 (comment)
For issue brave/brave-browser#3962 .
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See error of
You might be having wrong system time or timezone setup on your device. Please setup the correct time and timezoneExpected result:
See error of
Your computer's clock may be set to the wrong time or time zone. Check your clock settings.Reviewer Checklist: