Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NOTREACHED_NORETURN in domain block throttle. #24292

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Use NOTREACHED_NORETURN in domain block throttle. #24292

merged 1 commit into from
Jun 20, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jun 20, 2024 •
edited
Loading

Resolves brave/brave-browser#39161

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov marked this pull request as ready for review June 20, 2024 09:34
@goodov goodov enabled auto-merge (squash) June 20, 2024 09:35
cdesouza-chromium
cdesouza-chromium approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodov goodov merged commit 8834b76 into master Jun 20, 2024
20 checks passed
@goodov goodov deleted the issues/39161 branch June 20, 2024 11:31
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 20, 2024
@emerick emerick mentioned this pull request Jun 25, 2024
Merged
24 tasks
emerick pushed a commit that referenced this pull request Jun 25, 2024
@goodov @emerick
Use NOTREACHED_NORETURN in domain block throttle. (#24292)
33514d3
@mkarolin mkarolin mentioned this pull request Jul 2, 2024
Merged
24 tasks
mkarolin pushed a commit that referenced this pull request Jul 2, 2024
@goodov @mkarolin
Use NOTREACHED_NORETURN in domain block throttle. (#24292)
2f75630
kjozwiak pushed a commit that referenced this pull request Jul 3, 2024
@emerick @goodov
@simonhong @mkarolin @samartnik
Upgrade from Chromium 126 to Chromium 127 (uplift to 1.68.x). (#24372)
e54671f 
* Merge pull request #23829 from brave/cr127

Upgrade from Chromium 126 to Chromium 127

* Support IndexedHostContentSettingsMap feature in Brave provider. (#24027)

* Use NOTREACHED_NORETURN in domain block throttle. (#24292)

* Fixed omnibox flickering with download toolbar button toggle

fix brave/brave-browser#39373

Our download button used smaller image size than other toolbar buttons.
Set same icon size with other toolbar buttons.

* Merge pull request #24391 from brave/cr127-followup-remove-redundant-sidepanel-settings

Remove redundant side panel settings

* Merge pull request #24394 from brave/127.0.6533.26_master

Upgrade from Chromium 127.0.6533.17 to Chromium 127.0.6533.26

* Merge pull request #24422 from brave/fix_app_menu_button_upgrade_alert_regression

Fix app menu button upgrade alert regression

* Merge pull request #24412 from brave/android_tablet_ntp_fix

[C127] [Android] Fix for tablet NTP crash

* Merge pull request #24425 from brave/android_tablet_no_tabs_ui_fix

[C127] [Android] Fix for tablet overview UI with no tabs

* Merge pull request #24428 from brave/maxk-hide-history-groups-menu-item

Hides Grouped History menu item.

* Merge pull request #24460 from brave/android_webapps_branding_fix

[C127] [Android] Fix for web app branding icon and string

---------

Co-authored-by: goodov <5928869+goodov@users.noreply.github.com>
Co-authored-by: Simon Hong <shong@brave.com>
Co-authored-by: Max Karolinskiy <41635752+mkarolin@users.noreply.github.com>
Co-authored-by: samartnik <30602739+samartnik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesouza-chromium cdesouza-chromium cdesouza-chromium approved these changes

@SergeyZhukovsky SergeyZhukovsky Awaiting requested review from SergeyZhukovsky

Assignees

@goodov goodov

Labels
None yet
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging this pull request may close these issues.

Remove NOTREACHED in domain_block_navigation_throttle.cc
2 participants
@goodov @cdesouza-chromium