Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #TipWithBrave hashtag to twip #2495

Merged
merged 2 commits into from May 28, 2019
Merged

Add #TipWithBrave hashtag to twip #2495

merged 2 commits into from May 28, 2019

Conversation

@emerick
Copy link
Contributor

emerick commented May 24, 2019

Fixes brave/brave-browser#4555

Submitter Checklist:

Test Plan:

  • Enable Brave Rewards
  • Visit Twitter web site
  • Click the tip icon to tip a particular tweet
  • Send the tip
  • Press the "Tweet" button to tweet about the tip
  • Verify that #TipWithBrave hashtag appears in the posted tweet

Also need to perform the same verification steps when tipping on Twitter from the Rewards panel.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@emerick emerick requested a review from NejcZdovc May 24, 2019
@emerick emerick self-assigned this May 24, 2019
@emerick emerick force-pushed the twips-hashtag branch from ce6ff5e to 5773c71 May 27, 2019
@emerick emerick requested a review from NejcZdovc May 27, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 27, 2019
@emerick emerick force-pushed the twips-hashtag branch from 29fbb54 to 6afdd7f May 27, 2019
@emerick emerick force-pushed the twips-hashtag branch 2 times, most recently from b63d772 to 29d536e May 27, 2019
@emerick
Copy link
Contributor Author

emerick commented May 27, 2019

@NejcZdovc Fixed linter.

@emerick emerick requested a review from NejcZdovc May 27, 2019
@emerick emerick merged commit d5ee13d into master May 28, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emerick emerick deleted the twips-hashtag branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.