Skip to content

/ brave-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetShareURL tests for Twitter #2517

Merged
merged 1 commit into from May 28, 2019
Merged

Fix GetShareURL tests for Twitter #2517

merged 1 commit into from May 28, 2019

Conversation

@emerick
Copy link
Contributor

emerick commented May 28, 2019 •
edited

Fix brave/brave-browser#4625

Fix failing GetShareURL tests for Twitter (were passing on Windows, but failing on Mac).
@emerick
Fix GetShareURL tests for Twitter
Loading status checks…
bd422a7
@emerick emerick requested a review from NejcZdovc May 28, 2019
@emerick emerick self-assigned this May 28, 2019
@NejcZdovc
NejcZdovc approved these changes May 28, 2019
View changes
@emerick emerick merged commit 5346714 into master May 28, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emerick emerick deleted the fix-twitter-share-url-tests branch May 28, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc

Assignees

@emerick emerick

Labels
feature/rewards
Projects
None yet
Milestone
  0.67.x - Release
Linked issues

Successfully merging this pull request may close these issues.

Fix GetShareURL tests for Twitter
2 participants
@emerick @NejcZdovc
You can’t perform that action at this time.