Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 commits they don't want you to know about the brand new welcome screen #256

Merged
merged 3 commits into from Jul 16, 2018

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jul 13, 2018

@cezaraugusto cezaraugusto self-assigned this Jul 13, 2018
@cezaraugusto cezaraugusto requested a review from bbondy Jul 13, 2018
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

@NejcZdovc NejcZdovc Jul 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run this svg through https://jakearchibald.github.io/svgomg/

Copy link
Member

@bbondy bbondy Jul 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do the png opt in a follow up

color='primary'
size='large'
theme={theme.mainButton}
href='chrome://settings'
Copy link
Member

@bbondy bbondy Jul 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for all links, match the import screen where it uses a new tab.
Please do as a follow up.

bbondy
bbondy approved these changes Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants