3 commits they don't want you to know about the brand new welcome screen #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
welcome-screen
branch
from
abbc8ad
to
7b29fc1
Compare
NejcZdovc
reviewed
Jul 14, 2018
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Please run this svg through https://jakearchibald.github.io/svgomg/
There was a problem hiding this comment.
let's do the png opt in a follow up
bbondy
reviewed
Jul 16, 2018
| color='primary' | ||
| size='large' | ||
| theme={theme.mainButton} | ||
| href='chrome://settings' |
There was a problem hiding this comment.
I think for all links, match the import screen where it uses a new tab.
Please do as a follow up.
bbondy
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes brave/brave-browser#276