Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: mutation observer #2727
Closed
WIP: mutation observer #2727
Conversation
Snuupy
force-pushed the
mutationObserver
branch
2 times, most recently
from
8507493
to
c9f627f
antonok-edm
force-pushed the
mutationObserver
branch
4 times, most recently
from
54e822f
to
ffe5f03
antonok-edm
force-pushed the
mutationObserver
branch
5 times, most recently
from
8f0626f
to
81c15a4
notes change order mutation observer WIP browser tests isIdempotent isIdempotent mutation observer mutationObserver mutation observer mutationObserver mutation observer commented mutation observer for anton cleanup comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Snuupy commentedJun 18, 2019
•
edited
Submitter Checklist:
closes brave/brave-browser#3041, brave/brave-browser#94 (comment)
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Block element with !important html tag or is asynchronously added to the webpage (ex. reddit/facebook with filters added) and see that those ads are blocked.
If no rules are added, mutation observer is not triggered.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.