Adds wallet entry to settings bar in unofficial builds

[ryanml]

Fixes: brave/brave-browser#4581
Fixes: brave/brave-browser#5006

is_official_build=false

is_official_build=true

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[NejcZdovc]

Probably we want to translate this? So we need to put something like [[walletTitle]] in here?

[ryanml]

@NejcZdovc I see Brave Rewards is not translated either, I assume because all of these other translated titles were inherited from chromium definitions directly. So there'd be some patching involved to add these, not sure how that fits within the scope of the issue but happy to accommodate

[ryanml]

Actually, I may be able to do this without patching, stay tuned

[NejcZdovc]

I think Brave Rewards is not translated because it's a name of the product (which we don't want to translate), where wallet is just a regular menu text like settings for example

[ryanml]

I've used the translations with no patch, and also updated the Brave Rewards translation, separate issue created. We have string keys for it in other places, in either case (I didn't know we weren't translating it in any capacity) we should use the existing locale for it, so that has been done.

[NejcZdovc]

cc @davidtemkin @mandar-brave for confirmation if we want to translate Brave Rewards in the menu

[davidtemkin]

seems like it has to be translated -- i.e, we can't use the English string "Brave Rewards" in (for example) the Korean locale.

how is , for example, the large "Brave Rewards" at the top of the Rewards Settings page handled?

[ryanml]

We are using a translatable string for every instance of Brave Rewards on the settings page, for consistency we should use the same here. Whether it gets translated or not with these changes we are prepared for both scenarios 👍