Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export and expose mojo type #2883

Merged
merged 1 commit into from Jul 9, 2019
Merged

Remove export and expose mojo type #2883

merged 1 commit into from Jul 9, 2019

Conversation

@jdkuki
Copy link
Contributor

jdkuki commented Jul 8, 2019

Resolves brave/brave-browser#5130
Minor addition to #2432

Submitter Checklist:

Test Plan:

See brave/brave-browser#5130

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
Resolves brave/brave-browser#5130
Minor addition to #2432
@jdkuki jdkuki requested a review from NejcZdovc Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 9, 2019
@jdkuki jdkuki merged commit 08aa62d into master Jul 9, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdkuki jdkuki deleted the contribution-info-refactor branch Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.