Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patches from Chromium 76.0.3809.62 to Chromium 77.0.3860.5 #3000

Closed
wants to merge 10 commits into from
Commits on Jul 24, 2019
  1. Update patches from Chromium 76.0.3809.62 to Chromium 77.0.3860.5

    mkarolin committed Jul 24, 2019
  2. Process version shouldn't create a source set.

    mkarolin committed Jul 24, 2019
    GN change disallows sources that aren't a source, header, or object file.
    We need to pass `process_only` flag to process_version to not create source_set
    out of the version file.
    
    GN change:
    
    https://gn.googlesource.com/gn/+/8730b0feb6b991fa47368566501ab9ccfb453c92
    
    commit	8730b0feb6b991fa47368566501ab9ccfb453c92
    author	Tom Anderson <thomasanderson@chromium.org>	Thu May 16 11:00:40 2019 -0700
    committer	Commit Bot <commit-bot@chromium.org>	Thu May 16 21:36:50 2019 +0000
    
    Disallow non-buildable sources in binary targets
    
    When adding a file that's not a source, header, or object file to a source_set,
    loadable_module, shared_library, executable, or static_library, gn will now
    generate an error like the following:
    
    ERROR at //third_party/protobuf/proto_library.gni:369:15: Only source, header,
    and object files belong in the sources of a
    source_set. //out/Test/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of
    the valid types.
        sources = get_target_outputs(":$action_name")
                  ^---------------------------------
    See //google_apis/gcm/BUILD.gn:78:1: whence it was called.
    proto_library("proto") {
    ^-----------------------
    See //BUILD.gn:89:7: which caused the file to be included.
          "//google_apis/gcm:gcm_unit_tests",
          ^---------------------------------
    
    BUG=77
  3. Fixes dependency in brave/app/mac/BUILD.gn

    mkarolin committed Jul 24, 2019
    - Changes dependency from chrome_helper_app to chrome_helper_app_default
      since there are now mulitple 'chrome_helper_app's.
    
    Chromium changes:
    
    https://chromium.googlesource.com/chromium/src/+/4be2698e4784
    
    commit 4be2698e4784b68198d1062a54942ae232c57c24
    Author: Robert Sesek <rsesek@chromium.org>
    Date:   Mon Jun 17 17:41:28 2019 +0000
    
        Create more Mac Helper application bundles.
    
        In order to enable the hardened runtime, which restricts things such as
        writable-executable memory and loading code signed by a different Team
        ID, special code signing entitlements must be granted to the Helper.
        To keep the capabilities scoped to the process types that require them,
        this CL adds two new variants of the Helper app: one for renderers
        and one for plugins.
    
        Currently all three Helpers will be code signed in the same way without
        any entitlements, but this will change in the future.
    
        Tbr: dschuff@chromium.org
        Bug: 850193
Commits on Jul 25, 2019
  1. Updated chrome_constants override with the changes in the original.

    mkarolin committed Jul 25, 2019
    Chrominum changes:
    
    https://chromium.googlesource.com/chromium/src/+/b2720ad134127a6fdd35f92f44b5b2b946452c1b
    
    commit	b2720ad134127a6fdd35f92f44b5b2b946452c1b
    author	Nick Harper <nharper@chromium.org>	Fri Jul 12 22:07:10 2019
    committer	Commit Bot <commit-bot@chromium.org>	Fri Jul 12 22:07:10 2019
    tree	f850eb08e89e08373a37378fb43ea76064672a00
    parent	f070ecdf7436215ee672ff7b84a89f4eee90863c [diff]
    Remove Channel ID deletion code
    
    Bug: 903642, 975114
    
    https://chromium.googlesource.com/chromium/src/+/d1d11f3957428a77097d49e5fb2971b873d11f5d
    
    commit	d1d11f3957428a77097d49e5fb2971b873d11f5d	[log] [tgz]
    author	Xing Liu <xingliu@chromium.org>	Tue Apr 30 21:09:55 2019
    committer	Commit Bot <commit-bot@chromium.org>	Tue Apr 30 21:09:55 2019
    tree	d8778d132d6b3559a7c91fc12ff2873492e8b948
    parent	5e42b1a0fb34030b2e78b6453977cf4801bff761 [diff]
    Notification scheduler: Plumb dependencies to glue class.
    
    This CL plumbs dependencies into scheduler glue class, and starts to
    connects several subsystems together.
    
    Tests will be added in following CLs to keep this CL smaller, and
    there are still many things not implemented in the glue layer yet.
    
    TBR=peter@chromium.org
    
    Bug: 930968
  2. OmniboxInputType::INVALID was renamed to EMPTY.

    mkarolin committed Jul 25, 2019
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/e31e15795d599fd8a53d04ed2bf8832e36fa0ead
    
    commit	e31e15795d599fd8a53d04ed2bf8832e36fa0ead
    author	Yue Ru Sun <yrsun@chromium.org>	Fri Jul 19 17:09:57 2019
    committer	Commit Bot <commit-bot@chromium.org>	Fri Jul 19 17:09:57 2019
    tree	b5d9b74dae9b156ce8c6abb4d635f8d84480ea88
    parent	fb39b07fe2369060544e7cadc86f82cba2e43bb8 [diff]
    Sync omnibox type proto change
    
    Field name has changed from INVALID to EMPTY in cl/255470920, this patch syncs that change and fix all occurrences.
    
    See https://bugs.chromium.org/p/chromium/issues/detail?id=983220
    
    Bug: 983220
Commits on Jul 31, 2019
  1. Updated HandleExternalProtocol signature in BraveContentBrowserClient.

    mkarolin committed Jul 31, 2019
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/b6042ed37a482983111cdf1f9d0b09ffe972c309
    
    commit b6042ed37a482983111cdf1f9d0b09ffe972c309
    Author: Clark DuVall <cduvall@chromium.org>
    Date:   Mon Jul 15 17:20:45 2019 +0000
    
        Support HandleExternalProtocol on UI thread
    
        This allows HandleExternalProtocol to be used on the UI thread in
        android_webview. This is part of migrating the navigation loader to the
        UI thread.
    
        Bug: 824840
  2. Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…

    mkarolin committed Jul 31, 2019
    …rkRequest.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/1d81619dbd351cb570943140bddac7a80559dd76
    
    commit 1d81619dbd351cb570943140bddac7a80559dd76
    Author: Clark DuVall <cduvall@chromium.org>
    Date:   Fri Jul 19 19:54:42 2019 +0000
    
        Move WebRequest to the UI thread
    
        Now that network service is launched, there is no reason to have
        WebRequest run on the IO thread. This moves all WebRequest code and
        the WebRequestProxyingURLLoaderFactory to the UI thread, which
        eliminates thread hops. For more info, see the Chrome IO Thread
        Simplification: Planning doc:
        https://docs.google.com/document/d/1fowGQ8xWBv4YqHj_YbK-S3wpmJQDE7L0-GwNR_vAkHE/edit#
    
        Change-Id: I5ba8954c5d91c98c96a66558ecb659b59ff4386c
        Bug: 980774
  3. AddRestoredTab now takes a tab group param.

    mkarolin committed Jul 31, 2019
    For Brave importer profile writer added a nullptr optional for tab group.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/81999fd6a771e38cccc487364728ba91f5fc17f2
    
    commit 81999fd6a771e38cccc487364728ba91f5fc17f2
    Author: Collin Baker <collinbaker@chromium.org>
    Date:   Wed Jun 5 23:12:27 2019 +0000
    
        Save and restore tab groups
    
        This implements basic session restore functionality for tab
        groups. Currently, only whole browser session restore is supported;
        restoring a window or a tab from the history menu won't restore
        groups.
    
        Bug: 905491
  4. content/public interfaces are no longer const.

    mkarolin committed Jul 31, 2019
    Removed const from overrides.
    
    Chromium change:
    
    https://chromium.googlesource.com/chromium/src/+/4b4eed074e848347f5a5b07d4d4b3fd2f6e13820
    
    commit 4b4eed074e848347f5a5b07d4d4b3fd2f6e13820
    Author: Lucas Furukawa Gadani <lfg@chromium.org>
    Date:   Tue Jun 4 23:12:04 2019 +0000
    
        Remove const interfaces from content/public.
    
        Tbr: boliu@chromium.org, dvadym@chromium.org, bengr@chromium.org
        Bug: 908139
  5. Update strings for 77.0.3860.5

    mkarolin committed Jul 25, 2019
You can’t perform that action at this time.