Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Crypto Wallets menu item in official builds #3006

Merged
merged 1 commit into from Jul 25, 2019
Merged

Conversation

@ryanml
Copy link
Member

ryanml commented Jul 25, 2019

Fixes: brave/brave-browser#5383

Uses brave_wallet_enabled over is_official_build. Should be uplifted to Dev

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@ryanml ryanml added this to the 0.70.x - Nightly milestone Jul 25, 2019
@ryanml ryanml requested review from bridiver and bbondy Jul 25, 2019
@ryanml ryanml self-assigned this Jul 25, 2019
@ryanml ryanml force-pushed the fix-menu-item branch from 9ed2d23 to fa2f6b6 Jul 25, 2019
@bbondy
bbondy approved these changes Jul 25, 2019
@ryanml ryanml merged commit 2287df1 into master Jul 25, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryanml ryanml deleted the fix-menu-item branch Jul 25, 2019
ryanml added a commit that referenced this pull request Jul 25, 2019
Removes Crypto Wallets menu item in official builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.