PrefProvider::is_incognito_ was renamed to off_the_record_.

Updated name in constructor of our override BravePrefProvider.

Chromim change:

https://chromium.googlesource.com/chromium/src/+/94c80d547af89125e18831420d57562117c8e348

commit 94c80d547af89125e18831420d57562117c8e348
Author: Ramin Halavati <rhalavati@chromium.org>
Date:   Tue Jun 4 06:13:36 2019 +0000

    Replace incognito with off_the_record in ContentSettingsPref*.

    ContentSettingsPref and ContentSettingsPrefProfovider classes receive
    an |incognito| argument that actually triggers the off-the-record
    behavior and is not necessarily an incognito mode specifier.
    The argument and all related items are renamed to off_the_record to
    remove ambiguity.

    Bug: 968028

components/content_settings/core/browser/brave_content_settings_pref_provider.cc

@@ -15,9 +15,9 @@
 namespace content_settings {
 
 BravePrefProvider::BravePrefProvider(PrefService* prefs,
-                                     bool incognito,
+                                     bool off_the_record,
                                      bool store_last_modified)
-    : PrefProvider(prefs, incognito, store_last_modified) {
+    : PrefProvider(prefs, off_the_record, store_last_modified) {
   brave_pref_change_registrar_.Init(prefs_);
 
   WebsiteSettingsRegistry* website_settings =
@@ -29,8 +29,7 @@ BravePrefProvider::BravePrefProvider(PrefService* prefs,
           info->type(),
           std::make_unique<ContentSettingsPref>(
               info->type(), prefs_, &brave_pref_change_registrar_,
-              info->pref_name(),
-              is_incognito_,
+              info->pref_name(), off_the_record_,
               base::Bind(&PrefProvider::Notify, base::Unretained(this)))));
       return;
     }

components/content_settings/core/browser/brave_content_settings_pref_provider.h

@@ -22,8 +22,9 @@ namespace content_settings {
 // EphemeralProvider ignore shields type and this class handles.
 class BravePrefProvider : public PrefProvider {
  public:
-  BravePrefProvider(
-      PrefService* prefs, bool incognito, bool store_last_modified);
+  BravePrefProvider(PrefService* prefs,
+                    bool off_the_record,
+                    bool store_last_modified);
   ~BravePrefProvider() override {}
 
  private: