Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10 #3089

Closed
wants to merge 26 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a289bf5
Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10
mkarolin Jul 24, 2019
70ddd21
Process version shouldn't create a source set.
mkarolin Jul 24, 2019
68ceae3
Updated chrome_constants override with the changes in the original.
mkarolin Jul 25, 2019
3c5b5da
OmniboxInputType::INVALID was renamed to EMPTY.
mkarolin Jul 25, 2019
5990b61
Updated HandleExternalProtocol signature in BraveContentBrowserClient.
mkarolin Jul 31, 2019
df02c7d
Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…
mkarolin Jul 31, 2019
7665708
AddRestoredTab now takes a tab group param.
mkarolin Jul 31, 2019
84d8cbd
content/public interfaces are no longer const.
mkarolin Jul 31, 2019
94c08b2
.idl files aren't allowed in GN sources.
mkarolin Aug 2, 2019
466fcc1
Readded code to get top document GURL in NavigationRequest.
mkarolin Aug 2, 2019
bd45597
Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…
mkarolin Aug 2, 2019
420c35e
PrefProvider::is_incognito_ was renamed to off_the_record_.
mkarolin Aug 2, 2019
591be33
APISignature::ParseArgumentsToJSON signature change.
mkarolin Aug 5, 2019
66a7c6d
ComponentLoader ctor signature change.
mkarolin Aug 5, 2019
40e5d24
SimplifyHttpsIndicator feature is now on by default.
mkarolin Aug 5, 2019
b434c77
Removed Win10 specific welcome UI flow.
mkarolin Aug 6, 2019
7ec6c6c
Signin restructure.
mkarolin Aug 6, 2019
6a2ba54
Use base::Contains instead of ContainsKey.
mkarolin Aug 6, 2019
7e70b0b
IOThread class has been removed.
mkarolin Aug 6, 2019
01aa4b4
Fixes compilation of brave_actions_container.h
mkarolin Aug 6, 2019
6445003
views::BoxLayout orientation is now a class enum.
mkarolin Aug 6, 2019
3d02930
Fixes RenderViewContextMenu override compilation.
mkarolin Aug 6, 2019
f4dc03c
BookmarkChangeProcessor overrides now use size_t.
mkarolin Aug 6, 2019
9221940
BookmarkNode::set_type was removed.
mkarolin Aug 5, 2019
7009ef4
Update strings for 77.0.3865.10.
mkarolin Jul 25, 2019
43ed3c5
TreeNode::GetChild and child_count were removed.
mkarolin Aug 7, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

APISignature::ParseArgumentsToJSON signature change.

The method now returns a struct instrad of having mutliple out params.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/4ed01619c8ae43d3a1ef1f8acd713aa6aaa3530b

commit 4ed01619c8ae43d3a1ef1f8acd713aa6aaa3530b
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date:   Thu Jul 18 17:41:55 2019 +0000

    [Extensions Bindings] Return a struct from APISignature parsing methods

    Make APISignature::ParseArgumentsToJSON(),
    APISignature::ParseArgumentsToV8(), and
    APISignature::ConvertArgumentsIgnoringSchema() return a struct
    containing the parse results, including arguments, error, and
    async response type (callback if one were provided).

    This will make it easier when we need to provide additional information
    about if a promise should be returned.

    No behavior change is expected.

    Bug: 978538
  • Loading branch information
mkarolin committed Aug 5, 2019
commit 591be33c208da5a54d3fd9157478ea00ac07ca68
@@ -120,15 +120,12 @@ void BraveShieldsContentSetting::HandleFunction(const std::string& method_name,
if (!access_checker_->HasAccessOrThrowError(context, full_name))
return;

std::unique_ptr<base::ListValue> converted_arguments;
v8::Local<v8::Function> callback;
std::string error;
const APISignature* signature = type_refs_->GetTypeMethodSignature(full_name);
if (!signature->ParseArgumentsToJSON(context, argument_list, *type_refs_,
&converted_arguments, &callback,
&error)) {
APISignature::JSONParseResult parse_result =
signature->ParseArgumentsToJSON(context, argument_list, *type_refs_);
if (!parse_result.succeeded()) {
arguments->ThrowTypeError(api_errors::InvocationError(
full_name, signature->GetExpectedSignature(), error));
full_name, signature->GetExpectedSignature(), *parse_result.error));
return;
}

@@ -148,10 +145,11 @@ void BraveShieldsContentSetting::HandleFunction(const std::string& method_name,
}
}

converted_arguments->Insert(0u, std::make_unique<base::Value>(pref_name_));
parse_result.arguments->Insert(0u, std::make_unique<base::Value>(pref_name_));
request_handler_->StartRequest(
context, "braveShields." + method_name, std::move(converted_arguments),
callback, v8::Local<v8::Function>(), binding::RequestThread::UI);
context, "braveShields." + method_name, std::move(parse_result.arguments),
parse_result.callback, v8::Local<v8::Function>(),
binding::RequestThread::UI);
}

} // namespace extensions
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.