Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10 #3089

Closed
wants to merge 26 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a289bf5
Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10
mkarolin Jul 24, 2019
70ddd21
Process version shouldn't create a source set.
mkarolin Jul 24, 2019
68ceae3
Updated chrome_constants override with the changes in the original.
mkarolin Jul 25, 2019
3c5b5da
OmniboxInputType::INVALID was renamed to EMPTY.
mkarolin Jul 25, 2019
5990b61
Updated HandleExternalProtocol signature in BraveContentBrowserClient.
mkarolin Jul 31, 2019
df02c7d
Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…
mkarolin Jul 31, 2019
7665708
AddRestoredTab now takes a tab group param.
mkarolin Jul 31, 2019
84d8cbd
content/public interfaces are no longer const.
mkarolin Jul 31, 2019
94c08b2
.idl files aren't allowed in GN sources.
mkarolin Aug 2, 2019
466fcc1
Readded code to get top document GURL in NavigationRequest.
mkarolin Aug 2, 2019
bd45597
Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…
mkarolin Aug 2, 2019
420c35e
PrefProvider::is_incognito_ was renamed to off_the_record_.
mkarolin Aug 2, 2019
591be33
APISignature::ParseArgumentsToJSON signature change.
mkarolin Aug 5, 2019
66a7c6d
ComponentLoader ctor signature change.
mkarolin Aug 5, 2019
40e5d24
SimplifyHttpsIndicator feature is now on by default.
mkarolin Aug 5, 2019
b434c77
Removed Win10 specific welcome UI flow.
mkarolin Aug 6, 2019
7ec6c6c
Signin restructure.
mkarolin Aug 6, 2019
6a2ba54
Use base::Contains instead of ContainsKey.
mkarolin Aug 6, 2019
7e70b0b
IOThread class has been removed.
mkarolin Aug 6, 2019
01aa4b4
Fixes compilation of brave_actions_container.h
mkarolin Aug 6, 2019
6445003
views::BoxLayout orientation is now a class enum.
mkarolin Aug 6, 2019
3d02930
Fixes RenderViewContextMenu override compilation.
mkarolin Aug 6, 2019
f4dc03c
BookmarkChangeProcessor overrides now use size_t.
mkarolin Aug 6, 2019
9221940
BookmarkNode::set_type was removed.
mkarolin Aug 5, 2019
7009ef4
Update strings for 77.0.3865.10.
mkarolin Jul 25, 2019
43ed3c5
TreeNode::GetChild and child_count were removed.
mkarolin Aug 7, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

BookmarkNode::set_type was removed.

Type is now passed as a constructor param to BookmarkPermanentNode, so
updated our subclass to do the same.
Added BraveBookmarkNode class that subclasses BookmarkNode and takes
Type as a parameter so that we can construct BookmarkNode of types other
than URL and FOLDER.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/91f0b53ac9a6a8ba83be403ed5937598fbb2cb2d

commit 91f0b53ac9a6a8ba83be403ed5937598fbb2cb2d
Author: Pauline Leitao <psivieroleitao@google.com>
Date:   Tue Jul 9 10:13:54 2019 +0000

    Make BookmarkNode type immutable

    BookmarkNode types are currently mutable and either set with a
    set_type() method or inferred from URL validity. This CL changes this
    set-up so that type is defined within the constructor and remains
    unchanged throughout the existence of the BookmarkNode. This is not only
    more coherent with the concept of type itself, but also removes the
    redundancy of calling set_type() after having instantiated a
    BookmarkNode whose type was already automatically set to the same thing.
    It also rectifies certain incoherences within other parts of the code,
    such as the need to re-set permanent node types after decoding them,
    which had previously caused the BookmarkNode type to be changed to
    Folder.

    Objectively, this CL does the following:
    1. Changed the main BookmarkNode constructor to take in a type instead
    of calculating it internally.
    2. Changed helper BookmarkNode constructors that take in less parameters
    to compute node type within them based on URL validity.
    3. Additional helper BookmarkNode constructors were added to allow for
    the creation of nodes with explicit type but not every other parameter.
    4. Changed the BookmarkPermanentNode constructor to always take in a
    type instead of inferring it from other pieces of information.

    Bug: 980301
  • Loading branch information
mkarolin committed Aug 5, 2019
commit 9221940e5eea0e37e989d5c77a8f30cb6d293ae4
@@ -21,8 +21,9 @@ class BraveSyncServiceObserver;
class Settings;
class SyncDevices;

bookmarks::BookmarkPermanentNodeList
LoadExtraNodes(bookmarks::LoadExtraCallback callback, int64_t* next_node_id);
bookmarks::BookmarkPermanentNodeList LoadExtraNodes(
bookmarks::LoadManagedNodeCallback callback,
int64_t* next_node_id);
bool IsSyncManagedNode(const bookmarks::BookmarkPermanentNode* node);

class BraveSyncService : public KeyedService {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.