Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10 #3089
Update patches from Chromium 76.0.3809.87 to Chromium 77.0.3865.10 #3089
Changes from 1 commit
a289bf570ddd2168ceae33c5b5da5990b61df02c7d766570884d8cbd94c08b2466fcc1bd45597420c35e591be3366a7c6d40e5d24b434c777ec6c6c6a2ba547e70b0b01aa4b464450033d02930f4dc03c92219407009ef443ed3c5File filter...
Jump to…
.idl files aren't allowed in GN sources.
GN change disallows sources that aren't a source, header, or object file. Changed chromium_src/BUILD.gn to use `midl` action for the google_update_idl.idl file and then list that action as a dep for `google_update` source_set. GN change: https://gn.googlesource.com/gn/+/8730b0feb6b991fa47368566501ab9ccfb453c92 commit 8730b0feb6b991fa47368566501ab9ccfb453c92 author Tom Anderson <thomasanderson@chromium.org> Thu May 16 11:00:40 2019 -0700 committer Commit Bot <commit-bot@chromium.org> Thu May 16 21:36:50 2019 +0000 Disallow non-buildable sources in binary targets When adding a file that's not a source, header, or object file to a source_set, loadable_module, shared_library, executable, or static_library, gn will now generate an error like the following: ERROR at //third_party/protobuf/proto_library.gni:369:15: Only source, header, and object files belong in the sources of a source_set. //out/Test/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of the valid types. sources = get_target_outputs(":$action_name") ^--------------------------------- See //google_apis/gcm/BUILD.gn:78:1: whence it was called. proto_library("proto") { ^----------------------- See //BUILD.gn:89:7: which caused the file to be included. "//google_apis/gcm:gcm_unit_tests", ^--------------------------------- BUG=77