Unit tests: Fixes CreateProfileAsyncHelper signature.

ProfileManagerWithoutInit::CreateProfileAsyncHelper overridden in
TorUnittestProfileManager now returns unique_ptr to Profile.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/8f0b748a630d30d0cdc08cd2e4b6dd64b139e97b

commit 8f0b748a630d30d0cdc08cd2e4b6dd64b139e97b
Author: Daniel Hosseinian <dhoss@chromium.org>
Date:   Fri Jun 7 18:21:04 2019 +0000

    ProfileManager::RegisterTestingProfile() now takes a std::unique_ptr

    This commit clarifies previously established ownership semantics of
    Profiles within ProfileManager through the use of unique pointers.
    Changes were made to the parameters of
    ProfileManager::RegisterTestingProfile() and
    ProfileManager::RegisterProfile() to take a std::unique_ptr instead of a
    raw pointer. A further change was made to the return type of
    ProfileManager::CreateProfileAsyncHelper() from a raw pointer to a
    unique pointer. All callers to the aforementioned functions (including
    unit tests) that made calls to the two functions are updated to pass in
    unique pointers.

    Bug: 968187

browser/profiles/tor_unittest_profile_manager.cc

@@ -24,11 +24,12 @@ Profile* TorUnittestProfileManager::CreateProfileHelper(
     if (!base::CreateDirectory(path))
       return nullptr;
   }
-  return CreateProfile(path, nullptr);
+  return CreateProfile(path, nullptr).release();
 }
 
-Profile* TorUnittestProfileManager::CreateProfileAsyncHelper(
-    const base::FilePath& path, Delegate* delegate) {
+std::unique_ptr<Profile> TorUnittestProfileManager::CreateProfileAsyncHelper(
+    const base::FilePath& path,
+    Delegate* delegate) {
   // ThreadTaskRunnerHandle::Get() is TestingProfile's "async" IOTaskRunner
   // (ref. TestingProfile::GetIOTaskRunner()).
   base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ -46,7 +47,7 @@ void TorUnittestProfileManager::InitProfileUserPrefs(Profile* profile) {
   }
 }
 
-Profile* TorUnittestProfileManager::CreateProfile(
+std::unique_ptr<Profile> TorUnittestProfileManager::CreateProfile(
     const base::FilePath& path, Delegate* delegate) {
   TestingProfile::Builder profile_builder;
   sync_preferences::PrefServiceMockFactory factory;
@@ -58,6 +59,5 @@ Profile* TorUnittestProfileManager::CreateProfile(
   profile_builder.SetPrefService(std::move(prefs));
   profile_builder.SetPath(path);
   profile_builder.SetDelegate(delegate);
-  std::unique_ptr<TestingProfile> profile = profile_builder.Build();
-  return profile.release();
+  return profile_builder.Build();
 }

browser/profiles/tor_unittest_profile_manager.h

@@ -17,13 +17,14 @@ class TorUnittestProfileManager : public ProfileManagerWithoutInit {
  protected:
   Profile* CreateProfileHelper(const base::FilePath& path) override;
 
-  Profile* CreateProfileAsyncHelper(const base::FilePath& path,
-                                    Delegate* delegate) override;
+  std::unique_ptr<Profile> CreateProfileAsyncHelper(
+      const base::FilePath& path,
+      Delegate* delegate) override;
 
   void InitProfileUserPrefs(Profile* profile) override;
 
  private:
-  Profile* CreateProfile(const base::FilePath& path, Delegate* delegate);
+  std::unique_ptr<Profile> CreateProfile(const base::FilePath& path, Delegate* delegate);
 };
 
 #endif  // BRAVE_BROWSER_PROFILES_TOR_UNITTEST_PROFILE_MANAGER_H_