Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…

…essageLoopRun.

We used to start a number of our services in
BraveBrowserProcessImpl::ResourceDispatcherHostCreated, which was an
override of BrowserProcessImpl. However the method was removed in the
base class due to Chromium change to remove
ChromeResourceDispatcherHostDelegate.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/c098bc87fdf68370de521a35ade804d1d4ede9c2

commit c098bc87fdf68370de521a35ade804d1d4ede9c2
Author: John Abd-El-Malek <jam@chromium.org>
Date:   Fri May 31 19:33:55 2019 +0000

    Remove ChromeResourceDispatcherHostDelegate as it's not used anymore.

    Bug: 934009

browser/brave_browser_main_extra_parts.cc

@@ -30,4 +30,5 @@ void BraveBrowserMainExtraParts::PreMainMessageLoopRun() {
   // So, call it after browser threads are created.
   g_brave_browser_process->brave_widevine_bundle_manager()->StartupCheck();
 #endif
+  g_brave_browser_process->StartBraveServices();
 }

browser/brave_browser_process_impl.cc

@@ -89,8 +89,14 @@ BraveBrowserProcessImpl::brave_component_updater_delegate() {
   return brave_component_updater_delegate_.get();
 }
 
-void BraveBrowserProcessImpl::ResourceDispatcherHostCreated() {
-  BrowserProcessImpl::ResourceDispatcherHostCreated();
+ProfileManager* BraveBrowserProcessImpl::profile_manager() {
+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
+  if (!created_profile_manager_)
+    CreateProfileManager();
+  return profile_manager_.get();
+}
+
+void BraveBrowserProcessImpl::StartBraveServices() {
   ad_block_service()->Start();
   ad_block_custom_filters_service()->Start();
   ad_block_regional_service_manager()->Start();
@@ -106,13 +112,6 @@ void BraveBrowserProcessImpl::ResourceDispatcherHostCreated() {
   local_data_files_service()->Start();
 }
 
-ProfileManager* BraveBrowserProcessImpl::profile_manager() {
-  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  if (!created_profile_manager_)
-    CreateProfileManager();
-  return profile_manager_.get();
-}
-
 brave_shields::AdBlockService* BraveBrowserProcessImpl::ad_block_service() {
   if (ad_block_service_)
     return ad_block_service_.get();

browser/brave_browser_process_impl.h

@@ -57,10 +57,10 @@ class BraveBrowserProcessImpl : public BrowserProcessImpl {
   ~BraveBrowserProcessImpl() override;
 
   // BrowserProcess implementation.
-  void ResourceDispatcherHostCreated() override;
 
   ProfileManager* profile_manager() override;
 
+  void StartBraveServices();
   brave_shields::AdBlockService* ad_block_service();
   brave_shields::AdBlockCustomFiltersService* ad_block_custom_filters_service();
   brave_shields::AdBlockRegionalServiceManager*