Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update patches from Chromium 76.0.3809.100 to Chromium 77.0.3865.35 #3180

Closed
wants to merge 51 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
423a083
Update patches from Chromium 76.0.3809.100 to Chromium 77.0.3865.35
mkarolin Jul 24, 2019
bd9ec36
Process version shouldn't create a source set.
mkarolin Jul 24, 2019
d3f7753
Updated chrome_constants override with the changes in the original.
mkarolin Jul 25, 2019
1ab6a1a
OmniboxInputType::INVALID was renamed to EMPTY.
mkarolin Jul 25, 2019
94ca89d
Updated HandleExternalProtocol signature in BraveContentBrowserClient.
mkarolin Jul 31, 2019
62db6f1
Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…
mkarolin Jul 31, 2019
fcad3da
AddRestoredTab now takes a tab group param.
mkarolin Jul 31, 2019
c288e60
content/public interfaces are no longer const.
mkarolin Jul 31, 2019
e9d0417
Removed unused source_set from the build.
mkarolin Aug 2, 2019
51e9a45
Readded code to get top document GURL in NavigationRequest.
mkarolin Aug 2, 2019
04a52ec
Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…
mkarolin Aug 2, 2019
7356b53
PrefProvider::is_incognito_ was renamed to off_the_record_.
mkarolin Aug 2, 2019
001d02b
APISignature::ParseArgumentsToJSON signature change.
mkarolin Aug 5, 2019
a85619c
ComponentLoader ctor signature change.
mkarolin Aug 5, 2019
28afa6d
SimplifyHttpsIndicator feature is now on by default.
mkarolin Aug 5, 2019
780ef50
Removed Win10 specific welcome UI flow.
mkarolin Aug 6, 2019
41b5d1f
Signin restructure.
mkarolin Aug 6, 2019
ac771a5
Use base::Contains instead of ContainsKey.
mkarolin Aug 6, 2019
5ab6339
IOThread class has been removed.
mkarolin Aug 6, 2019
6cb9e48
Fixes compilation of brave_actions_container.h
mkarolin Aug 6, 2019
b7f5923
views::BoxLayout orientation is now a class enum.
mkarolin Aug 6, 2019
47fbab7
Fixes RenderViewContextMenu override compilation.
mkarolin Aug 6, 2019
35fce2e
Enable networking service.
mkarolin Aug 10, 2019
58c6807
Fixes location change of md_select_css.html.
mkarolin Aug 13, 2019
fdae8cf
GridLayout::AddView now takes unique_ptr.
mkarolin Aug 13, 2019
53b5099
GridLayout c'tor signature change.
mkarolin Aug 13, 2019
672cf89
Signature change in WillCreateURLLoaderFactory in
mkarolin Aug 14, 2019
f4050a9
Removed BraveNetworkDelegateBase and subclasses.
mkarolin Aug 14, 2019
e1d5146
Removed AllowGetCookie/AllowSetCookie from BraveContentBrowserClient.
mkarolin Aug 16, 2019
cccb7d4
StringDataSource replaced StringDataPipeProducer.
mkarolin Aug 15, 2019
abbd577
Fixes Chromium bluetooth UUID dependency bug.
mkarolin Aug 17, 2019
cda6703
TreeNode::GetChild and child_count were removed.
mkarolin Aug 20, 2019
ff7751d
syncer::Cryptographer c'tor signature change.
mkarolin Aug 20, 2019
fe976d2
Added a missing header include.
mkarolin Aug 20, 2019
37232ce
paper-button has been replaced with cr-button.
mkarolin Aug 19, 2019
5bc7db7
Fixes missing pref in Shields settings radio buttons.
mkarolin Aug 20, 2019
024cef0
Transition CSS from [dark] to @media.
mkarolin Aug 20, 2019
9625fa3
Unit tests: Fixes MCSClient API signature changes.
mkarolin Aug 12, 2019
8fc861a
Unit tests: fixes GCMDriver c'tor signature change.
mkarolin Aug 12, 2019
54d16c0
Unit tests: Fixes CreateProfileAsyncHelper signature.
mkarolin Aug 12, 2019
c85d11c
Unit test: BraveSyncServiceTest.GetDisableReasons fix.
mkarolin Aug 21, 2019
54b356e
Browser Test: SendToOmniboxAndSubmit signature change.
mkarolin Aug 21, 2019
42fe586
Browser Test: added missing overrides to BraveMockRenderViewContextMenu.
mkarolin Aug 21, 2019
49d495f
Browser Test: Removed SetUrlRequestMocksEnabled.
mkarolin Aug 21, 2019
1c405a2
Browser Test: Added a missing header include.
mkarolin Aug 21, 2019
884a909
Browser Test: Rename ContextualSuggestionsService => RemoteSuggestion…
mkarolin Aug 21, 2019
2fe7418
Browser Test: clean up disabled features.
mkarolin Aug 22, 2019
8dd6ea2
Moved starting of Brave services to PostBrowserStart.
mkarolin Aug 22, 2019
bfe3812
Browser Test: Allow intentional crash.
mkarolin Aug 22, 2019
67605b2
Update strings for 77.0.3865.19.
mkarolin Jul 25, 2019
8a0679d
TEMPORARY: commented out code affected by Chromium commit 6811de35a39…
mkarolin Aug 16, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fixes RenderViewContextMenu override compilation.

Removed unnecessary spellcheck/os build flags checks.

The flag was causing the include not to happen due to a this change:

https://chromium.googlesource.com/chromium/src/+/de74ce301c50fd3a4815faff207c9592416eb337

commit de74ce301c50fd3a4815faff207c9592416eb337
Author: Siye Liu <siliu@microsoft.com>
Date:   Thu Jun 20 20:44:43 2019 +0000

    windows spellchecker integration.

    This CL aims to implement windows spellchecker integration in Chromium
    project, so that user can switch to use windows spellchecker or
    hunspell spellchecker at run time. We need to implement platform
    agnostic interfaces to integrate windows spellchecker into Chromium. We
    also need to refactor some code to enable runtime switch between
    Windows spellchecker and hunspell spellchecker.

    We have outlines following steps to achieve the goal:

    (1) Implement spellcheck_platform interface.
          spellcheck_platform is an interface that platform-specific
          spellchecker needs to implement. Create spellcheck_platform_win.cc
          which contains Windows specific logic. All COM calls are happeninn
          on the background thread. spellcheck_platform API are all async.

    (2) Refactor SpellCheckHostChromeImpl.
          SpellCheckHostChromeImpl is a derived class from SpellCheckHost
          which provides basic spellcheck support. Mac has separate
          implementation located at spell_check_host_chrome_impl_mac.cc.
          Windows can share the same implementation, therefore, I move the
          code to the base derived class at spellcheck_host_chrome_impl.cc
          and delete mac specific file.

    (3) Refactor SpellingRequest.
          SpellingRequest is owned by SpellCheckHostChromeImpl and is
          currently located at spell_check_host_chrome_impl_mac.cc file.
          Created seperate files spelling_request.h and spelling_request.cc
          for defination and declaration of SpellingRequest.

    (4) Refactor CreateNativeSpellingEngine().
          CreateNativeSpellingEngine() used to live in seperate files for
          different spellcheckers. For platform specific spellchecker, it
          is located at platform_spelling_engine.cc. For hunspell
          spellchecker, it is located at hunspell_engine.cc. In order to
          enable runtime switch between those two spellcheck services, We
          need to have a uniformed definiation. Therefore, I create a new
          fine spelling_engine.cc base class and put a uniformed defination
          of CreateNativeSpellingEngine().

    (5) Define USE_RENDERER_SPELLCHECKER build flag
          We already have USE_BROWSER_SPELLCHECKER build flag. The decision
          to use platform specific spellcheck or hunspell spellcheck is
          made at build time. It's not the case anymore. We want to switch
          between spellcheck services at runtime. use browser spellcheck
          (platform specific spellcheck) and use renderer spellcheck
          (hunspll spellcheck) are no longer mutually exclusive. I created
          USE_RENDERER_SPELLCHECKER build flag to indicate usage of
          hunspell spellcheck service.

    (6) create feature flag kWinUseBrowserSpellChecker.
          In order to enable runtime switch between two spellcheck services.
          We need to have a feature flag to indicate which spellcheck
          services to use. I created kWinUseBrowserSpellChecker. The flag
          only has effect on Windows.

    (7) Create spellcheck::UseBrowserSpellChecker()
          In order to enable runtime switch between platform specific
          spellcheck and hunspell spellcheck, we need a runtime check
          instead of build time check. I created a runtime check an put it
          in file spellcheck_features.cc. For Windows, the method will check
          for feature flag kWinUseBrowserSpellChecker to determine which
          spellcheck service to use. On all other platforms, it will return
          build time flag.

    After these steps, we enabled Windows Spellcheck Services integration
    and also achieved runtime switch between platform spellchecker and
    hunspell spellchecker for windows platform.

    Bug: 463364
  • Loading branch information
mkarolin committed Aug 6, 2019
commit 47fbab79bd6c7adf21565b80699fc6a0f2348192
@@ -7,26 +7,19 @@
#include "brave/browser/profiles/profile_util.h"
#include "brave/browser/tor/buildflags.h"
#include "brave/browser/translate/buildflags/buildflags.h"
#include "components/spellcheck/spellcheck_buildflags.h"
#if !BUILDFLAG(USE_BROWSER_SPELLCHECKER)
#include "brave/browser/renderer_context_menu/brave_spelling_options_submenu_observer.h"
#endif

// Our .h file creates a masquerade for RenderViewContextMenu. Switch
// back to the Chromium one for the Chromium implementation.
#undef RenderViewContextMenu
#define RenderViewContextMenu RenderViewContextMenu_Chromium

#if !defined(OS_MACOSX)
// Use our subclass to initialize SpellingOptionsSubMenuObserver.
#define SpellingOptionsSubMenuObserver BraveSpellingOptionsSubMenuObserver
#endif

#include "../../../../chrome/browser/renderer_context_menu/render_view_context_menu.cc" // NOLINT

#if !defined(OS_MACOSX)
#undef SpellingOptionsSubMenuObserver
#endif

// Make it clear which class we mean here.
#undef RenderViewContextMenu
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.