New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update patches from Chromium 76.0.3809.100 to Chromium 77.0.3865.35 #3180
Closed
+1,713
−2,568
Closed
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
423a083
Update patches from Chromium 76.0.3809.100 to Chromium 77.0.3865.35
mkarolin bd9ec36
Process version shouldn't create a source set.
mkarolin d3f7753
Updated chrome_constants override with the changes in the original.
mkarolin 1ab6a1a
OmniboxInputType::INVALID was renamed to EMPTY.
mkarolin 94ca89d
Updated HandleExternalProtocol signature in BraveContentBrowserClient.
mkarolin 62db6f1
Updated signature of BraveExtensionsAPIClient::ShouldHideBrowserNetwo…
mkarolin fcad3da
AddRestoredTab now takes a tab group param.
mkarolin c288e60
content/public interfaces are no longer const.
mkarolin e9d0417
Removed unused source_set from the build.
mkarolin 51e9a45
Readded code to get top document GURL in NavigationRequest.
mkarolin 04a52ec
Moved start of Brave services to BraveBrowserMainExtraParts::PreMainM…
mkarolin 7356b53
PrefProvider::is_incognito_ was renamed to off_the_record_.
mkarolin 001d02b
APISignature::ParseArgumentsToJSON signature change.
mkarolin a85619c
ComponentLoader ctor signature change.
mkarolin 28afa6d
SimplifyHttpsIndicator feature is now on by default.
mkarolin 780ef50
Removed Win10 specific welcome UI flow.
mkarolin 41b5d1f
Signin restructure.
mkarolin ac771a5
Use base::Contains instead of ContainsKey.
mkarolin 5ab6339
IOThread class has been removed.
mkarolin 6cb9e48
Fixes compilation of brave_actions_container.h
mkarolin b7f5923
views::BoxLayout orientation is now a class enum.
mkarolin 47fbab7
Fixes RenderViewContextMenu override compilation.
mkarolin 35fce2e
Enable networking service.
mkarolin 58c6807
Fixes location change of md_select_css.html.
mkarolin fdae8cf
GridLayout::AddView now takes unique_ptr.
mkarolin 53b5099
GridLayout c'tor signature change.
mkarolin 672cf89
Signature change in WillCreateURLLoaderFactory in
mkarolin f4050a9
Removed BraveNetworkDelegateBase and subclasses.
mkarolin e1d5146
Removed AllowGetCookie/AllowSetCookie from BraveContentBrowserClient.
mkarolin cccb7d4
StringDataSource replaced StringDataPipeProducer.
mkarolin abbd577
Fixes Chromium bluetooth UUID dependency bug.
mkarolin cda6703
TreeNode::GetChild and child_count were removed.
mkarolin ff7751d
syncer::Cryptographer c'tor signature change.
mkarolin fe976d2
Added a missing header include.
mkarolin 37232ce
paper-button has been replaced with cr-button.
mkarolin 5bc7db7
Fixes missing pref in Shields settings radio buttons.
mkarolin 024cef0
Transition CSS from [dark] to @media.
mkarolin 9625fa3
Unit tests: Fixes MCSClient API signature changes.
mkarolin 8fc861a
Unit tests: fixes GCMDriver c'tor signature change.
mkarolin 54d16c0
Unit tests: Fixes CreateProfileAsyncHelper signature.
mkarolin c85d11c
Unit test: BraveSyncServiceTest.GetDisableReasons fix.
mkarolin 54b356e
Browser Test: SendToOmniboxAndSubmit signature change.
mkarolin 42fe586
Browser Test: added missing overrides to BraveMockRenderViewContextMenu.
mkarolin 49d495f
Browser Test: Removed SetUrlRequestMocksEnabled.
mkarolin 1c405a2
Browser Test: Added a missing header include.
mkarolin 884a909
Browser Test: Rename ContextualSuggestionsService => RemoteSuggestion…
mkarolin 2fe7418
Browser Test: clean up disabled features.
mkarolin 8dd6ea2
Moved starting of Brave services to PostBrowserStart.
mkarolin bfe3812
Browser Test: Allow intentional crash.
mkarolin 67605b2
Update strings for 77.0.3865.19.
mkarolin 8a0679d
TEMPORARY: commented out code affected by Chromium commit 6811de35a39…
mkarolin File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Removed unused source_set from the build.
Got flagged because .idl files aren't allowed as GN sources in
source_sets any more due to the GN change below. This particular
source_set wasn't being used anywhere and can be removed.
GN change:
https://gn.googlesource.com/gn/+/8730b0feb6b991fa47368566501ab9ccfb453c92
commit 8730b0feb6b991fa47368566501ab9ccfb453c92
author Tom Anderson <thomasanderson@chromium.org> Thu May 16 11:00:40 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Thu May 16 21:36:50 2019 +0000
Disallow non-buildable sources in binary targets
When adding a file that's not a source, header, or object file to a source_set,
loadable_module, shared_library, executable, or static_library, gn will now
generate an error like the following:
ERROR at //third_party/protobuf/proto_library.gni:369:15: Only source, header,
and object files belong in the sources of a
source_set. //out/Test/pyproto/google_apis/gcm/protocol/mcs_pb2.py is not one of
the valid types.
sources = get_target_outputs(":$action_name")
^---------------------------------
See //google_apis/gcm/BUILD.gn:78:1: whence it was called.
proto_library("proto") {
^-----------------------
See //BUILD.gn:89:7: which caused the file to be included.
"//google_apis/gcm:gcm_unit_tests",
^---------------------------------
BUG=77- Loading branch information
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@simonhong, what is the purpose of this source_set? Seems like we use a patch on //google_update/BUILD.gn to use this .idl file. (Disregard my change - that's just to pacify GN).