Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCrypto wallets link now present in official builds #3181
Merged
+13
−19
Conversation
| @@ -1,12 +1,8 @@ | |||
| import("//tools/grit/grit_rule.gni") | |||
| import("//ui/webui/webui_features.gni") | |||
| import("//brave/components/brave_wallet/browser/buildflags/buildflags.gni") | |||
This comment has been minimized.
This comment has been minimized.
ryanml
Aug 14, 2019
Author
Member
Mods to this file are no longer needed, as var check is no longer done. Originally added here https://github.com/brave/brave-core/pull/2729/files#diff-48d6a163ef47a669f467774cd3b96e9b and later modified here https://github.com/brave/brave-core/pull/3006/files#diff-48d6a163ef47a669f467774cd3b96e9b
ryanml
added a commit
that referenced
this pull request
Aug 14, 2019
Crypto wallets link now present in official builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedAug 14, 2019
Fixes brave/brave-browser#5666
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.