Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie pref value is an int, not a bool #3218

Merged
merged 1 commit into from Aug 21, 2019
Merged

cookie pref value is an int, not a bool #3218

merged 1 commit into from Aug 21, 2019

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Aug 20, 2019

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bridiver bridiver requested a review from iefremov Aug 20, 2019
@bridiver bridiver self-assigned this Aug 20, 2019
@bridiver bridiver added this to the 0.71.x - Nightly milestone Aug 20, 2019
@bridiver bridiver force-pushed the chromium-cookie-prefs branch from 2546623 to a8fb160 Aug 20, 2019
@bridiver bridiver requested review from simonhong and bbondy Aug 20, 2019
@bridiver bridiver force-pushed the chromium-cookie-prefs branch from a8fb160 to 3ee5909 Aug 20, 2019
Copy link
Collaborator

simonhong left a comment

++

@bridiver bridiver merged commit 65a115b into master Aug 21, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bridiver bridiver deleted the chromium-cookie-prefs branch Aug 21, 2019
bridiver added a commit that referenced this pull request Aug 28, 2019
cookie pref value is an int, not a bool
bridiver added a commit that referenced this pull request Aug 29, 2019
cookie pref value is an int, not a bool
@bridiver bridiver mentioned this pull request Aug 29, 2019
bridiver added a commit that referenced this pull request Aug 29, 2019
cookie pref value is an int, not a bool
@bsclifton
Copy link
Member

bsclifton commented Sep 12, 2019

Milestone set properly as 0.71.x, commit viewable in https://github.com/brave/brave-core/commits/0.71.x?after=886f8520767f78e257397cfa47ef585b35bf1aca+174

Will need to uplift to 0.70.x 👍

bsclifton added a commit that referenced this pull request Sep 12, 2019
cookie pref value is an int, not a bool
@bsclifton bsclifton mentioned this pull request Sep 12, 2019
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.