Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcookie pref value is an int, not a bool #3218
Merged
Conversation
|
++ |
bridiver
added a commit
that referenced
this pull request
Aug 28, 2019
cookie pref value is an int, not a bool
bridiver
added a commit
that referenced
this pull request
Aug 29, 2019
cookie pref value is an int, not a bool
Merged
bridiver
added a commit
that referenced
this pull request
Aug 29, 2019
cookie pref value is an int, not a bool
|
Milestone set properly as 0.71.x, commit viewable in https://github.com/brave/brave-core/commits/0.71.x?after=886f8520767f78e257397cfa47ef585b35bf1aca+174 Will need to uplift to 0.70.x |
bsclifton
added a commit
that referenced
this pull request
Sep 12, 2019
cookie pref value is an int, not a bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedAug 20, 2019
•
edited
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.